1466346 - search bar (STRG + F) close button ends up off screen

Status: RESOLVED DUPLICATE of bug 1222710

(Toolkit :: Find Toolbar, defect, P3)

Description

[Djfe]

Attachment: screenshot.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180516032328

Steps to reproduce:

Pushed the Firefox window to the right half of the screen (Windows Aero) and searched for something on the page.


Actual results:

The text that tells you that Firefox started searching from the beginning of the page again pushes the close button off screen.

Comment 2

[Djfe]

still happening and probably fairly easy to fix.
I would be greatful if this could be marked as a good first bug :)

Comment 3

[Thorsten Huber]

Related:
https://bugzilla.mozilla.org/show_bug.cgi?id=998364
https://bugzilla.mozilla.org/show_bug.cgi?id=1034346
https://bugzilla.mozilla.org/show_bug.cgi?id=1222710

Comment 4

[Thorsten Huber]

In fact it's probably a duplicate of the last one, bug 1222710.

Comment 5

[Thorsten Huber]

Sadly can't edit my comments, so have to add another.

Let's keep bug 1466346 because it has higher priority than bug 1222710.

Per discussion there, P5 means it's unlikely to ever be fixed, unless someone comes up with a patch which the Mozilla devs would only need to approve. I wonder if the posted work-around would be good enough as a real bug fix? Except that it shouldn't go to userChrome.css , but somewhere else.

.findbar-closebutton { -moz-box-ordinal-group: 0 !important; }

Comment 6

[Thorsten Huber]

Attachment: userChrome.css How to turn this user fix into an official one?

This is a user side fix, how to turn this into an official bug fix?

Source: https://bugzilla.mozilla.org/show_bug.cgi?id=1222710#c7

Comment 7

[Dale Harvey (:daleharvey)]

Please dont abuse flags like that

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch has instructions for how to submit a patch, taking a very quick look a real fix is very unlikely to use "!important"

Comment 8

[Thorsten Huber]

(In reply to Dale Harvey (:daleharvey) from comment #7)

Please dont abuse flags like that

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch has instructions for how to submit a patch, taking a very quick look a real fix is very unlikely to use "!important"

Sorry!

I think I found the file where the above CSS ID is used, and it does have a couple of "!important" flags in there. There's probably a better way, but it's as much as I know to fix the bug.

https://github.com/mozilla/gecko-dev/blob/master/toolkit/themes/shared/findBar.inc.css

It's currently this:

.findbar-closebutton {
padding: 0 8px;
}

Comment 9

[Thorsten Huber]

https://github.com/mozilla/gecko-dev/blob/master/toolkit/content/widgets/findbar.js

Line 30: this.content = MozXULElement.parseXULToFragment(`

At the end there's <toolbarbutton anonid="find-closebutton" which could be moved to the top. Alternatively maybe there's a way to keep to close button from moving outside the visible area. E.g. a CSS style which attaches it to the right border.