1466440 - Problem with browser.sessionstore.restore_on_demand for pinned tabs when disabled for normal tabs (Nightly v.62.0a1)

Status: NEW

(Firefox :: Session Restore, defect, P3)

Description

[Andy Lu]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180603221731

Steps to reproduce:

Go to about:config and set browser.sessionstore.restore_on_demand to false and browser.sessionstore.restore_pinned_tabs_on_demand to true; any other combination of the two except for this one will work correctly. After that, just exit Firefox and restart it.


Actual results:

Normal tabs will load themselves as expected, but pinned tabs will as well.


Expected results:

According to the about:config setting, pinned tabs shouldn't load unless they are the tab in view.

Comment 1

[Timea Cernea [:tbabos][inactive]]

Hey Andy,

This was a bit confusing. however you are right. Reproduced the issue on the latest Nightly 62.0a1 (2018-06-06) on Windows 10 x64.
Here are the results of combining the pref you also mentioned:

pinned tabs - true
session restore -true
all loading on demand

pinned tabs - false 
session restore - false 
all loaded without demand

pinned tabs- true
session restore - false
all loaded without demand!  <--- issue

pinned tabs - false
session restore true
pinned- loaded without demand
normal - loaded on demand

So basically, using the above preffs, you cannot set up a config that upon restarting Firefox pinned tabs will be loaded only on demand while normal tabs are loaded. 

Thank you for the report!

Comment 2

[Andy Lu]

(In reply to Timea Babos from comment #1)
> Hey Andy,
> 
> This was a bit confusing. however you are right. Reproduced the issue on the
> latest Nightly 62.0a1 (2018-06-06) on Windows 10 x64.
> Here are the results of combining the pref you also mentioned:
> 
> pinned tabs - true
> session restore -true
> all loading on demand
> 
> pinned tabs - false 
> session restore - false 
> all loaded without demand
> 
> pinned tabs- true
> session restore - false
> all loaded without demand!  <--- issue
> 
> pinned tabs - false
> session restore true
> pinned- loaded without demand
> normal - loaded on demand
> 
> So basically, using the above preffs, you cannot set up a config that upon
> restarting Firefox pinned tabs will be loaded only on demand while normal
> tabs are loaded. 
> 
> Thank you for the report!

No problem! Thanks for the reply and for confirming the bug!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 12 votes.
:dao, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 4

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.