1466450 - Animation Inspector's close button should be right aligned (without margin/padding right)

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect, P3)

Description

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: WIP-remove-the-margin-and-padding-from-close-button.patch

An animation inspector's clsoe button should not have the right margin and padding.

STR:
 1. Open Animation inspector
 2. select animation and show the keyframe panel.

AR:
 The close button of keyframe panel should be right alinged.

ER:
 The close button has right padding and margin.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1466450 - Remove margin and end padding from close button of animation inspector.

This patch will remove tab indent as well and make close button of animation
inspector to be right aligned.

Review commit: https://reviewboard.mozilla.org/r/249214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249214/

Comment 2

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8983311 [details]
Bug 1466450 - Remove margin and end padding from close button of animation inspector.

https://reviewboard.mozilla.org/r/249214/#review255358

Thanks!

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8983311 [details]
Bug 1466450 - Remove margin and end padding from close button of animation inspector.

https://reviewboard.mozilla.org/r/249214/#review255358

Thank you so much for the review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9acec00d0492
Remove margin and end padding from close button of animation inspector. r=daisuke

Comment 5

[Mantaroh Yoshinaga[:mantaroh]]

Sorry, I added 'leave-open' since I forgot applying photon icon style to this close button. I will submit it as second patch.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9acec00d0492

Comment 7

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Part 2. Apply the photon icon color style to the close button of animation inspactor.

(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #5)
> Sorry, I added 'leave-open' since I forgot applying photon icon style to
> this close button. I will submit it as second patch.

Daisuke,
I forgot applying the phtoon icon style to animation inspector's close button.
This patch will applyt it. Could you please review this patch?

Comment 8

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8983621 [details] [diff] [review]
Part 2. Apply the photon icon color style to the close button of animation inspactor.

Thank you!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/355fe159b162
Apply photon icon color style to the close button of animation inspector. r=daisuke

Comment 10

[Mantaroh Yoshinaga[:mantaroh]]

(In reply to Daisuke Akatsuka (:daisuke) from comment #8)
> Comment on attachment 8983621 [details] [diff] [review]
> Part 2. Apply the photon icon color style to the close button of animation
> inspactor.
> 
> Thank you!

Thank you for the review!

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/355fe159b162