Closed
Bug 1466450
Opened 4 years ago
Closed 4 years ago
Animation Inspector's close button should be right aligned (without margin/padding right)
Categories
(DevTools :: Inspector: Animations, defect, P3)
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: mantaroh, Assigned: mantaroh)
Details
Attachments
(2 files, 1 obsolete file)
An animation inspector's clsoe button should not have the right margin and padding. STR: 1. Open Animation inspector 2. select animation and show the keyframe panel. AR: The close button of keyframe panel should be right alinged. ER: The close button has right padding and margin.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Attachment #8982971 -
Attachment is obsolete: true
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mantaroh
Comment 2•4 years ago
|
||
mozreview-review |
Comment on attachment 8983311 [details] Bug 1466450 - Remove margin and end padding from close button of animation inspector. https://reviewboard.mozilla.org/r/249214/#review255358 Thanks!
Attachment #8983311 -
Flags: review?(dakatsuka) → review+
Assignee | ||
Comment 3•4 years ago
|
||
mozreview-review-reply |
Comment on attachment 8983311 [details] Bug 1466450 - Remove margin and end padding from close button of animation inspector. https://reviewboard.mozilla.org/r/249214/#review255358 Thank you so much for the review.
Pushed by mantaroh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9acec00d0492 Remove margin and end padding from close button of animation inspector. r=daisuke
Assignee | ||
Comment 5•4 years ago
|
||
Sorry, I added 'leave-open' since I forgot applying photon icon style to this close button. I will submit it as second patch.
Keywords: leave-open
Comment 6•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9acec00d0492
Assignee | ||
Comment 7•4 years ago
|
||
(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #5) > Sorry, I added 'leave-open' since I forgot applying photon icon style to > this close button. I will submit it as second patch. Daisuke, I forgot applying the phtoon icon style to animation inspector's close button. This patch will applyt it. Could you please review this patch?
Attachment #8983621 -
Flags: review?(dakatsuka)
Comment 8•4 years ago
|
||
Comment on attachment 8983621 [details] [diff] [review] Part 2. Apply the photon icon color style to the close button of animation inspactor. Thank you!
Attachment #8983621 -
Flags: review?(dakatsuka) → review+
Pushed by mantaroh@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/355fe159b162 Apply photon icon color style to the close button of animation inspector. r=daisuke
Assignee | ||
Comment 10•4 years ago
|
||
(In reply to Daisuke Akatsuka (:daisuke) from comment #8) > Comment on attachment 8983621 [details] [diff] [review] > Part 2. Apply the photon icon color style to the close button of animation > inspactor. > > Thank you! Thank you for the review!
Keywords: leave-open
Comment 11•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/355fe159b162
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•