1466478 - mfbt build fails on Solaris intel - error: __float128 is not supported on this target

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180516032328

Steps to reproduce:

It appeared to me for the first time on June 1st (31th May was ok).

When building Firefox on Solaris intel it fails like this (on sparc it builds just fine):

 4:58.71 gmake[4]: Entering directory '/scratch/firefox/obj-x86_64-pc-solaris2.11/mfbt'
 4:58.71 mkdir -p '.deps/'
 4:58.74 /usr/bin/clang++ -o Unified_cpp_mfbt_tests_gtest0.o -c -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers -include /scratch/firefox/config/gcc_hidden.h -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/scratch/firefox/mfbt/tests/gtest -I/scratch/firefox/obj-x86_64-pc-solaris2.11/mfbt/tests/gtest -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nspr -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /scratch/firefox/obj-x86_64-pc-solaris2.11/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -WstBUILDSTATUS BUILD_VERBOSE mfbt
 4:58.74 /usr/bin/clang -std=gnu99 -o lz4.o -c -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers -include /scratch/firefox/config/gcc_hidden.h -DDEBUG=1 -DIMPL_MFBT -DLZ4LIB_VISIBILITY= -I/scratch/firefox/mfbt -I/scratch/firefox/obj-x86_64-pc-solaris2.11/mfbt -I/scratch/firefox/mfbt/double-conversion -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nspr -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nss -fPIC -include /scratch/firefox/obj-x86_64-pc-solaris2.11/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fno-math-errno -pthread -pipe -g -O -fno-omit-frame-pointer  -MD -MP -MF .deps/lz4.o.pp   /scratch/firefox/mfbt/lz4.c
 4:58.75 ring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -O -fno-omit-frame-pointer  -MD -MP -MF .deps/Unified_cpp_mfbt_tests_gtest0.o.pp   /scratch/firefox/obj-x86_64-pc-solaris2.11/mfbt/tests/gtest/Unified_cpp_mfbt_tests_gtest0.cpp
 4:58.94 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/mfbt/tests/gtest/Unified_cpp_mfbt_tests_gtest0.cpp:2:
 4:58.94 In file included from /scratch/firefox/mfbt/tests/gtest/TestSpan.cpp:19:
 4:58.95 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/gtest/gtest.h:54:
 4:58.95 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers/limits:50:
 4:58.95 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/mozilla/mozalloc.h:16:
 4:58.95 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers/new:44:
 4:58.95 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers/new:3:
 4:58.95 In file included from /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/new:40:
 4:58.95 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers/exception:3:
 4:58.96 In file included from /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/exception:143:
 4:58.96 In file included from /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/bits/nested_exception.h:40:
 4:58.96 In file included from /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/bits/move.h:54:
 4:58.96 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers/type_traits:44:
 4:58.96 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers/type_traits:3:
 4:58.97 /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/type_traits:347:39: error: __float128 is not supported on this target
 4:58.97     struct __is_floating_point_helper<__float128>
 4:58.97                                       ^
 4:59.08 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/mfbt/tests/gtest/Unified_cpp_mfbt_tests_gtest0.cpp:2:
 4:59.08 In file included from /scratch/firefox/mfbt/tests/gtest/TestSpan.cpp:19:
 4:59.08 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/gtest/gtest.h:54:
 4:59.08 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers/limits:50:
 4:59.09 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/mozilla/mozalloc.h:21:
 4:59.09 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers/cstdlib:44:
 4:59.09 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers/cstdlib:3:
 4:59.09 In file included from /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/cstdlib:77:
 4:59.09 /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/bits/std_abs.h:102:7: error: __float128 is not supported on this target
 4:59.10   abs(__float128 __x)
 4:59.10       ^
 4:59.10 /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/../../../../include/c++/7.3.0/bits/std_abs.h:101:3: error: __float128 is not supported on this target
 4:59.10   __float128
 4:59.10   ^
 5:02.15 3 errors generated.
 5:02.15 gmake[4]: *** [/scratch/firefox/config/rules.mk:1033: Unified_cpp_mfbt_tests_gtest0.o] Error 1
 5:02.15 gmake[4]: Leaving directory '/scratch/firefox/obj-x86_64-pc-solaris2.11/mfbt/tests/gtest'
 5:02.15 gmake[3]: *** [/scratch/firefox/config/recurse.mk:73: mfbt/tests/gtest/target] Error 2
 5:02.15 gmake[3]: *** Waiting for unfinished jobs....
 5:02.15 mfbt

Comment 1

[Petr Sumbera]

Ok. Maybe it's following LLVM issue https://reviews.llvm.org/D41240. I will check it.

Comment 2

[Petr Sumbera]

I can confirm it's llvm/clang issue (see above). Closing the bug.

Comment 3

[Petr Sumbera]

For record this was introduced by:

changeset:   420577:07db1154d5b9
user:        Mike Hommey <[e-mail]>
date:        Thu May 31 01:16:10 2018 +0000
description:
        Bug 1253064 - Prefer Clang to GCC in local developer builds. r=gps

        For Android targets, we just ignore plain clang, it's unlikely to work.