Closed
Bug 14665
Opened 25 years ago
Closed 21 years ago
unreachable code in mailnews/compose/src/nsMsgSendPart.cpp
Categories
(MailNews Core :: Composition, defect, P3)
MailNews Core
Composition
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.2alpha
People
(Reporter: colin, Assigned: bugzilla)
Details
(Whiteboard: code clean-up)
Attachments
(1 file)
|
1.26 KB,
patch
|
KaiE
:
review+
dmosedale
:
superreview+
sspitzer
:
approval1.4b+
|
Details | Diff | Splinter Review |
In mailnews/compose/src/nsMsgSendPart.cpp there is the code segment:
NS_ASSERTION(MIME_BUFFER_SIZE > 1000, "buffer size out of range");
My compiler grumbles because this is always true and therefore the test
is not needed (MIME_BUFFER_SIZE is a #define'd to 4096). Intead of a run
time check, wouldn't a compile time check be more appropriate? Something
like:
#if MIME_BUFFER_SIZE < 1000
#error MIME_BUFFER_SIZE must be at least 1000
#endif
Colin.
|
Assignee | |
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M14
|
|
Assignee | |
Comment 1•25 years ago
|
||
Thanks Collin.
|
||
Updated•25 years ago
|
Target Milestone: M14 → M16
|
|
Assignee | |
Comment 4•23 years ago
|
||
Accepting
Whiteboard: code clean-up
Target Milestone: Future → mozilla0.9.6
|
||
Updated•23 years ago
|
Target Milestone: mozilla1.0 → mozilla1.2
QA Contact: lchiang → stephend
|
||
Comment 6•21 years ago
|
||
heres a patch that just removes the assertion and adds a comment by the define
|
|
||
Updated•21 years ago
|
Attachment #121886 -
Flags: superreview?(dmose)
Attachment #121886 -
Flags: review?(ducarroz)
|
||
Comment 7•21 years ago
|
||
Comment on attachment 121886 [details] [diff] [review] patch sr=dmose
Attachment #121886 -
Flags: superreview?(dmose) → superreview+
|
||
Comment 8•21 years ago
|
||
Comment on attachment 121886 [details] [diff] [review] patch r=kaie
Attachment #121886 -
Flags: review?(ducarroz) → review+
|
|
||
Comment 9•21 years ago
|
||
Comment on attachment 121886 [details] [diff] [review] patch this is a super trivial patch.
Attachment #121886 -
Flags: approval1.4b?
|
||
Comment 10•21 years ago
|
||
Comment on attachment 121886 [details] [diff] [review] patch a=sspitzer stuart, hacking mailnews, april 2003?
Attachment #121886 -
Flags: approval1.4b? → approval1.4b+
|
|
||
Comment 11•21 years ago
|
||
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Verified via code inspection (using LXR).
Status: RESOLVED → VERIFIED
|
||
Updated•20 years ago
|
Product: MailNews → Core
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
| Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•