Closed Bug 1466513 Opened 6 years ago Closed 6 years ago

Remove pessimizing std::move in EffectSet.h

Categories

(Core :: DOM: Animation, enhancement)

Product:
Core
Component:
DOM: Animation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1465060

People

(Reporter: jfkthame, Unassigned)

Details

clang says that std::move isn't a good idea here:

 0:13.61 obj-x86_64-apple-darwin17.5.0-opt-nodebug/dist/include/mozilla/EffectSet.h:93:23: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
 0:13.61       , mHashIterator(std::move(aEffectSet.mEffects.Iter()))
 0:13.61                       ^
 0:13.62 obj-x86_64-apple-darwin17.5.0-opt-nodebug/dist/include/mozilla/EffectSet.h:93:23: note: remove std::move call here
 0:13.62       , mHashIterator(std::move(aEffectSet.mEffects.Iter()))
 0:13.62                       ^~~~~~~~~~                          ~
 0:26.46 1 warning generated.

So I guess we should follow the compiler's advice.
Oh, never mind, this is covered in bug 1465060.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.