1466558 - Provide Haxe Language Syntax Highlighting

Status: RESOLVED FIXED

(DevTools :: Source Editor, enhancement, P3)

Description

[David Walsh :davidwalsh]

A debugger user has requested we add syntax highlighting for the haxe language:

https://github.com/devtools-html/debugger.html/pull/6456

We can easily add haxe to our development environment but it appears we need a separate step for adding Haxe inside the browser.

Comment 1

[chtsha024]

Just describing the use case for this here:

I use haxe transpiled to javascript with sourcemaps.
Many developers are using haxe-javascript as an alternative for flash.
Haxe has been growing in popularity for developing web games.

Comment 2

[213502460]

This would be useful. As a Haxe developer our only options for syntax highlighting is Chrome.

Comment 3

[cmandlbaur]

I've been itching to switch over the using Firefox for my day to day dev and debugging. This is the main outstanding issue for me tbh.

Comment 4

[Keeran]

This would be very helpful for me, I use Firefox for everything until it comes time to debug my code - it's rather bothersome to have to switch over to Chrome when I need to debug, this change would be greatly appreciated

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1466558 - Provide Haxe Language Syntax Highlighting.

Review commit: https://reviewboard.mozilla.org/r/249988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249988/

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

The best way to do test this is to paste in some Haxe code from https://try.haxe.org/ into the scratchpad. The github merge to add the file support in the debugger hasn't landed in m-c yet. Otherwise, you can manually apply the one line commit from https://github.com/devtools-html/debugger.html/pull/6456 and go to http://adireddy.github.io/demos/pixi-haxe/basics.html and look for Main.hx.

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=823676b796ab6c2d785b502a77657aad769bc368

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8984185 [details]
Bug 1466558 - Provide Haxe Language Syntax Highlighting.

https://reviewboard.mozilla.org/r/249988/#review256588

Adding the new mode looks fine to me. Unfortunately the minified bundle isn't possible to review - I assume that's the current bundle with the new mode folded into it? Looks like both are 5.38.0.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d517d39bdd
Provide Haxe Language Syntax Highlighting. r=bgrins

Comment 10

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 41d517d39bdd (bug 1466558) for devtools failures in devtools/client/sourceeditor/test/browser_vinemacs.js on a CLOSED TREE

Problematic push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=41d517d39bdd5070f84be8c8b8002b3944d5928e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&fromchange=eb4f880a8aa431cf6260aae3709f887bfdd6502f&selectedJob=182555217
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=182555217&repo=mozilla-inbound&lineNumber=2899
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0130f657be99498548ee315464186a39f4aa54ec&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

17:43:51    ERROR -  695 INFO TEST-UNEXPECTED-FAIL | devtools/client/sourceeditor/test/browser_vimemacs.js | Test 'sublime_insertLineAfter' failed -
17:43:51     INFO -  Stack trace:
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/head.js:codemirrorSetStatus:143
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/helper_codemirror_runner.js:listener:14
17:43:51     INFO -  data:,content.wrappedJSObject.mozilla_setStatus = function(statusMsg, type, customMsg) {  sendSyncMessage('setStatus', {statusMsg: statusMsg, type: type, customMsg: customMsg});};function check() {   var doc = content.document; var out = doc.getElementById('status');   if (!out || !out.classList.contains('done')) { return setTimeout(check, 100); }  sendAsyncMessage('done', { failed: content.wrappedJSObject.failed });}check();:content.wrappedJSObject.mozilla_setStatus:1
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/vimemacs.html:displayTest:203
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step:71
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step/<:89
17:43:51     INFO -  setTimeout handler*chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step:89
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step/<:89
17:43:51     INFO -  setTimeout handler*chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step:89
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step/<:89
17:43:51     INFO -  setTimeout handler*chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step:89
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step/<:89
17:43:51     INFO -  setTimeout handler*chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:step:89
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/driver.js:runTests:95
17:43:51     INFO -  chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/vimemacs.html:runHarness:144
17:43:51     INFO -  EventHandlerNonNull*chrome://mochitests/content/browser/devtools/client/sourceeditor/test/codemirror/vimemacs.html:null:88
17:43:51     INFO -  696 INFO {line:1,ch:2,sticky:null} != {line:1,ch:0,sticky:null} (anchor 0)
17:43:51     INFO -  Not taking screenshot here: see the one that was previously logged
17:43:51    ERROR -  697 INFO TEST-UNEXPECTED-FAIL | devtools/client/sourceeditor/test/browser_vimemacs.js | Test 'sublime_insertLineBefore' failed -

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad337f9e2fcf
Provide Haxe Language Syntax Highlighting. r=bgrins

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ad337f9e2fcf