1466560 - Link to privacy policy and/or other relevant contributor and user docs in the footer

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Chris AtLee [:catlee]]

STR:

1) Scroll down to the bottom of a differential page e.g. https://phabricator.services.mozilla.com/D1511
2) Click on "Add Action", then "Accept Revision"

The "Submit" button on the bottom-right scrolls down off the bottom of the page. I need to re-scroll the page in order to click on the button.

Comment 1

[Mark Côté [:mcote]]

Filed upstream.

Comment 2

[Mark Côté [:mcote]]

Upstream are reticent to do anything here.  epriestly posted a long reply, a few salient points of which are here:

"Changes here (at least, changes which work by adjusting the scroll position after making a dropdown selection) are likely to have a relatively high maintenance cost because a fairly large number of other behaviors interact with page scroll position in complex ways"

"Scrolling the page down by the height delta of the new content is also bad in the general case -- it moves the <select /> away from under the mouse, making selection of multiple actions more difficult."

"A somewhat-related request which has come up sometimes in the past is 'Huge Green Accept Button' or 'Keystroke to Accept'. You're welcome to build these locally, but I'm philosophically resistant to them in the upstream because I believe an 'Accept' interaction should basically never be so cursory that scrolling the page 30 pixels or clicking dropdown is a meaningful increase in the cost of the action."

However, he did provide a workaround: "put something in ui.footer-items ... That will add content to the foot of the page and probably make 'scroll to the bottom, select actions' leave the 'Submit' button on screen."  I'll look into the latter.

Comment 3

[Mark Côté [:mcote]]

Morphing this bug.  We should probably link to the Mozilla privacy policy or such, at the minimum, and the footer seems as good a place as any.

Comment 4

[:glob ✱]

i've added privacy, cookies, and legal links to the footer of https://phabricator-dev.allizom.org/

r?mcote

Comment 5

[Mark Côté [:mcote]]

r+

Comment 6

[:glob ✱]

added to prod