Closed Bug 1466602 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 11330 - [LayoutNG] Need to know when establishing a new FC during min/max calculation.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11330 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11330
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Need to know when establishing a new FC during min/max calculation.
>  
>  When we have to lay out an object to determine its min/max inline size,
>  and the node establishes a new formatting context, we need to create a
>  constraint space that reflects this. The block size of the float needs
>  to be included in the block size of its container, because this block
>  size will be the min/max preferred inline size of the container of that
>  container, if the writing modes are orthogonal.
>  
>  Avoid some duplicate code for creating the constraint space builder. The
>  second builder, the one that redoes layout with inifinte available space
>  now gets SetFloatsBfcOffset() called, which was previously missing, but
>  that must have been an oversight.
>  
>  This fixes the recently introduced regression with
>  fast/multicol/vertical-rl/column-rules.html and also another test.
>  
>  Wrote a new test that tests exactly what I wanted to fix as well.
>  
>  Bug: 847807
>  Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
>  Change-Id: I7b28a0ef8061fc3089deb488ad0a78b81776295d
>  Reviewed-on: https://chromium-review.googlesource.com/1084989
>  WPT-Export-Revision: 6c7c7bdf42033ec94424e1e49639bed40789b84d
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests
FAIL   : 1

New tests that have failures or other problems:
/css/css-writing-modes/float-in-htb-in-vrl.html: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e94891d59b8
[wpt PR 11330] - [LayoutNG] Need to know when establishing a new FC during min/max calculation., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ff137e10c3f
[wpt PR 11330] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/639f167c7b4d
[wpt PR 11330] - [LayoutNG] Need to know when establishing a new FC during min/max calculation., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d3432333a78
[wpt PR 11330] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/639f167c7b4d
https://hg.mozilla.org/mozilla-central/rev/0d3432333a78
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.