1466602 - [wpt-sync] Sync PR 11330 - [LayoutNG] Need to know when establishing a new FC during min/max calculation.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11330 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11330
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:
>  [LayoutNG] Need to know when establishing a new FC during min/max calculation.
>  
>  When we have to lay out an object to determine its min/max inline size,
>  and the node establishes a new formatting context, we need to create a
>  constraint space that reflects this. The block size of the float needs
>  to be included in the block size of its container, because this block
>  size will be the min/max preferred inline size of the container of that
>  container, if the writing modes are orthogonal.
>  
>  Avoid some duplicate code for creating the constraint space builder. The
>  second builder, the one that redoes layout with inifinte available space
>  now gets SetFloatsBfcOffset() called, which was previously missing, but
>  that must have been an oversight.
>  
>  This fixes the recently introduced regression with
>  fast/multicol/vertical-rl/column-rules.html and also another test.
>  
>  Wrote a new test that tests exactly what I wanted to fix as well.
>  
>  Bug: 847807
>  Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
>  Change-Id: I7b28a0ef8061fc3089deb488ad0a78b81776295d
>  Reviewed-on: https://chromium-review.googlesource.com/1084989
>  WPT-Export-Revision: 6c7c7bdf42033ec94424e1e49639bed40789b84d

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=039f5215a4de8ad6f5d06660e1d2b25af2163e05

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=724eb2f94cdb3bd9d26718c771d8564c1ce08791

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6488782e125c82670e77ba32f867ed541d5d1ca

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=44d4e52374153c5c1c28426f6783ca429974c8a6

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 1 tests
FAIL   : 1

New tests that have failures or other problems:
/css/css-writing-modes/float-in-htb-in-vrl.html: FAIL

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c523eb5122f3d3c35804531919da45310291355

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e94891d59b8
[wpt PR 11330] - [LayoutNG] Need to know when establishing a new FC during min/max calculation., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ff137e10c3f
[wpt PR 11330] - Update wpt metadata, a=testonly

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/639f167c7b4d
[wpt PR 11330] - [LayoutNG] Need to know when establishing a new FC during min/max calculation., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d3432333a78
[wpt PR 11330] - Update wpt metadata, a=testonly

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/639f167c7b4d
https://hg.mozilla.org/mozilla-central/rev/0d3432333a78