Followups to various recent bugs.

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(3 attachments)

Just things I told xidorn I'll do in followups :)
Assignee: nobody → emilio
Comment on attachment 8983138 [details]
Bug 1466609: #[parse(..)].

https://reviewboard.mozilla.org/r/248972/#review255640

::: servo/components/style/parser.rs:164
(Diff revision 1)
> -///    the value conditional on `function`, which will be invoked with a
> +///    value conditional on `function`, which will be invoked with a
>  ///    `&ParserContext` reference.

I think it would probably be clearer to write down the function signature directly, like:
> which should match type `fn(&ParserContext) -> bool`.
Attachment #8983138 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8983139 [details]
Bug 1466609: Make the threadsafe refcounting macros more reusable.

https://reviewboard.mozilla.org/r/248974/#review255646

::: servo/components/style/gecko_bindings/sugar/refptr.rs:278
(Diff revision 1)
>  // Companion of NS_DECL_THREADSAFE_FFI_REFCOUNTING.
>  //
>  // Gets you a free RefCounted impl implemented via FFI.
>  macro_rules! impl_threadsafe_refcount {
> -    ($t:ty, $addref:ident, $release:ident) => {
> +    ($t:ty, $addref:path, $release:path) => {
>          impl_refcount!($t, $addref, $release);

We can actually fold `impl_refcount` into this macro nowadays since there are no longer any non-threadsafe refcount... but it's not a big deal, and maybe we will add another in the future.
Attachment #8983139 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8983140 [details]
Bug 1466609: Make clearing atoms slightly more ergonomic.

https://reviewboard.mozilla.org/r/248976/#review255648

Thanks!
Attachment #8983140 - Flags: review?(xidorn+moz) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9889304ebdea
Move some parsing-only attributes to use #[parse(..)] instead of #[css(..)]. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/4607eea0048d
Make the threadsafe refcounting macros more reusable. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7785e8b5002
Make clearing atoms slightly more ergonomic. r=xidorn
You need to log in before you can comment on or make changes to this bug.