Closed Bug 1466630 Opened 6 years ago Closed 6 years ago

Port bug 1465933 - remove GetPIPNSSBundleString from nsINSSComponent - mailnews/extensions/smime/src/nsCertPicker.cpp:47:17: error: no member named 'GetPIPNSSBundleString' in 'nsINSSComponent'

Categories

(MailNews Core :: General, enhancement)

Product:
MailNews Core
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 62.0

People

(Reporter: jorgk-bmo, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

1466630.patch
2.50 KB, patch
keeler
: review+
Details | Diff | Splinter Review 
f16a2472bcb5 David Keeler — bug 1465933 - remove GetPIPNSSBundleString from nsINSSComponent r=fkiefer

/builds/worker/workspace/build/src/comm/mailnews/extensions/smime/src/nsCertPicker.cpp:47:17: error: no member named 'GetPIPNSSBundleString' in 'nsINSSComponent'
/builds/worker/workspace/build/src/comm/mailnews/extensions/smime/src/nsCertPicker.cpp:48:17: error: no member named 'GetPIPNSSBundleString' in 'nsINSSComponent'

Sadly my local build appears to be broken, so this could take a while to fix :-(
Attached patch 1466630.patch - WIP (obsolete) — — Splinter Review 
I've just removed the offending call. I have to see how to replace it.
Attached patch 1466630.patch — — Splinter Review 
This compiles for me.
Attachment #8983148 - Attachment is obsolete: true
Attachment #8983156 - Flags: review?(dkeeler)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/88e3ba430ffd
Port bug 1465933: Replace nsINSSComponent.GetPIPNSSBundleString with GetPIPNSSBundleString from nsNSSCertHelper. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 62.0
Comment on attachment 8983156 [details] [diff] [review]
1466630.patch

Review of attachment 8983156 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops - thought I searched for things like this. Sorry.
Anyway, lgtm.
Attachment #8983156 - Flags: review?(dkeeler) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0a38fa0a5979
Follow-up: remove unused variable. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: