Mercadolibre engines have the wrong encoding (and one wrong icon)

RESOLVED FIXED in Firefox 62

Status

()

defect
P1
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
Firefox 63
Points:
---

Firefox Tracking Flags

(firefox61 wontfix, firefox62+ fixed, firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Searching with international characters isn't working on Mercadolivre engines. Switching to UTF-8 fixes for all except for the .br version.

Also .br has the wrong icon.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
We don't have a deal with them anymore, so I'm going to fix the br engine to match the others and remove our codes.

Comment 4

a year ago
mozreview-review
Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

https://reviewboard.mozilla.org/r/248980/#review255384

Not sure if you want to change pt-BR in this bug or in a follow up, but the changes look good.
Attachment #8983142 - Flags: review?(francesco.lodolo) → review+
(Assignee)

Comment 5

a year ago
Once my list.json move lands, I'll fix all of these.
(Assignee)

Updated

a year ago
Priority: -- → P1
(In reply to Mike Kaply [:mkaply] from comment #5)
> Once my list.json move lands

Which bug is that? I don't think I've seen anything related to moving list.json, and I definitely need to update a bunch of tools.
Ah, that's bug 1437942. Didn't realize it was moving stuff around like that, I need to update scripts and documentation.
(Assignee)

Updated

11 months ago
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Comment 9

11 months ago
I know you already r+ the earlier patch, but thought you might want to look at the final patch.

Moved to UTF-8, fixed icon, removed our codes and fixed the mercadolivre engine to use the regular URLS.
Flags: needinfo?(francesco.lodolo)
(In reply to Mike Kaply [:mkaply] from comment #9)
> I know you already r+ the earlier patch, but thought you might want to look
> at the final patch.
> 
> Moved to UTF-8, fixed icon, removed our codes and fixed the mercadolivre
> engine to use the regular URLS.

Double checked and everything looks right.
Flags: needinfo?(francesco.lodolo)

Comment 11

11 months ago
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/f8598c3a26bb
Move MercadoLibre to UTF-8, https and fix icon. r=flod

Comment 12

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f8598c3a26bb
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

Updated

10 months ago
Summary: Mercadolivre engines have the wrong encoding (and one wrong icon) → Mercadolibre engines have the wrong encoding (and one wrong icon)
Mike, do you want to request uplift to 62?
Flags: needinfo?(mozilla)
(Assignee)

Comment 14

10 months ago
Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

Sure. No harm in it.

Approval Request Comment
[Feature/Bug causing the regression]: Cleanup search engine
[User impact if declined]: Search engines not working properly
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: Simple icon replacement, cleanup.
[String changes made/needed]:
Flags: needinfo?(mozilla)
Attachment #8983142 - Flags: approval-mozilla-beta?
Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

Changes limited to fixing MercadoLibre, let's go ahead and uplift for beta 8.
Attachment #8983142 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.