Closed
Bug 1466656
Opened 6 years ago
Closed 6 years ago
Gecko_CreateCSSErrorReporter should not allocate.
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
It's 5% on the test-case in bug 1466529.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•6 years ago
|
||
Comment on attachment 8983205 [details] Bug 1466656: Make ErrorReporter a smaller Rust type. Cam, if you could get to this before Xidorn it'd be nice, since he's going to be on PTO, and I want to profile the test-case in the blocked bug with this landed during the debugging and profiling training that starts tomorrow. Thanks in advance, and no worries if not (it just takes me to do an extra release build, so it's not too terrible :P).
Attachment #8983205 -
Flags: review?(cam)
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8983205 [details] Bug 1466656: Make ErrorReporter a smaller Rust type. https://reviewboard.mozilla.org/r/249056/#review255352
Attachment #8983205 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 5•6 years ago
|
||
Comment on attachment 8983205 [details] Bug 1466656: Make ErrorReporter a smaller Rust type. Thanks cam!
Attachment #8983205 -
Flags: review?(xidorn+moz)
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/00c3d250deca Make ErrorReporter a smaller Rust type. r=heycam
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00c3d250deca
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•