Closed Bug 1466661 Opened Last year Closed Last year

Do not build breakpad md5.cc on Linux

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Seems to be used only for Mac & Solaris
Comment on attachment 8983179 [details]
Bug 1466661 - Do not build breakpad md5.cc on Linux

https://reviewboard.mozilla.org/r/249032/#review258916

::: toolkit/crashreporter/google-breakpad/src/common/moz.build:15
(Diff revision 1)
>  UNIFIED_SOURCES += [
>      'convert_UTF.c',
>      'string_conversion.cc',
>  ]
>  
> -if CONFIG['OS_ARCH'] != 'WINNT':
> +if CONFIG['OS_ARCH'] not in ('WINNT', 'Linux'):

I would probably just switch this to `CONFIG['OS_ARCH'] == 'Darwin'` at this point. I don't think the Solaris build actually works anyway. (If you're not motivated to make that change I'm not opposed to you landing the patch as-is.)
Attachment #8983179 - Flags: review?(ted) → review+
Comment on attachment 8983179 [details]
Bug 1466661 - Do not build breakpad md5.cc on Linux

https://reviewboard.mozilla.org/r/249032/#review258916

> I would probably just switch this to `CONFIG['OS_ARCH'] == 'Darwin'` at this point. I don't think the Solaris build actually works anyway. (If you're not motivated to make that change I'm not opposed to you landing the patch as-is.)

sure :)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6aec9dc32d1c
Do not build breakpad md5.cc on Linux r=ted
https://hg.mozilla.org/mozilla-central/rev/6aec9dc32d1c
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.