1466673 - Remove nsITreeColumns

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Jorg, this one is going to need some mailnews changes.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Mark nsITreeColumns builtinclass

There are no JS implementors.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove use of nsITreeColumns in other xpidl interfaces

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Stop using nsITreeColumns in accessibility code

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Stop using nsITreeColumns in various other C++ code

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove the nsITreeColumns interface

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 8983301 [details] [diff] [review]
part 3.  Stop using nsITreeColumns in accessibility code

Review of attachment 8983301 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/nsCoreUtils.cpp
@@ +527,4 @@
>    if (!cols)
>      return nullptr;
>  
> +  RefPtr<nsTreeColumn> column = cols->GetFirstColumn();

It doesn't have to be a refptr, but the change will bloat your patch. If you could file a follow up good-first-bug on this, it'd be great.

::: accessible/xul/XULTreeAccessible.cpp
@@ +626,5 @@
>  
>    if (endCol == -1) {
> +    // We need to make sure to cast to int32_t before we do the subtraction, in
> +    // case the column count is 0.
> +    endCol = int32_t(treeColumns->Count()) - 1;

shouldn't you use static_cast instead of c-style casting?

Comment 8

[Boris Zbarsky [:bzbarsky]]

> If you could file a follow up good-first-bug on this, it'd be great.

You mean to make it a TreeColumn*?

> shouldn't you use static_cast instead of c-style casting?

I can do that, sure.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #8)
> > If you could file a follow up good-first-bug on this, it'd be great.
> 
> You mean to make it a TreeColumn*?

Right, that would require to make nsCoreUtils::GetFirstSensibleColumn returning a raw pointer as well, plus bunch of related changes.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34467aba5393
part 1.  Mark nsITreeColumns builtinclass.  r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/a122097d4ec3
part 2.  Remove use of nsITreeColumns in other xpidl interfaces.  r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce9fe4210ce
part 3.  Stop using nsITreeColumns in accessibility code.  r=surkov
https://hg.mozilla.org/integration/mozilla-inbound/rev/2095e4b302d2
part 4.  Stop using nsITreeColumns in various other C++ code.  r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/2628bc75afae
part 5.  Remove the nsITreeColumns interface.  r=mossop

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/34467aba5393
https://hg.mozilla.org/mozilla-central/rev/a122097d4ec3
https://hg.mozilla.org/mozilla-central/rev/1ce9fe4210ce
https://hg.mozilla.org/mozilla-central/rev/2095e4b302d2
https://hg.mozilla.org/mozilla-central/rev/2628bc75afae