Closed
Bug 1466673
Opened 5 years ago
Closed 5 years ago
Remove nsITreeColumns
Categories
(Core :: XUL, enhancement, P3)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(5 files)
758 bytes,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
8.75 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
6.02 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
3.90 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
7.21 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
No description provided.
![]() |
Assignee | |
Comment 1•5 years ago
|
||
Jorg, this one is going to need some mailnews changes.
![]() |
Assignee | |
Updated•5 years ago
|
Component: Layout → XUL
![]() |
Assignee | |
Comment 2•5 years ago
|
||
There are no JS implementors.
Attachment #8983299 -
Flags: review?(dtownsend)
![]() |
Assignee | |
Comment 3•5 years ago
|
||
Attachment #8983300 -
Flags: review?(dtownsend)
![]() |
Assignee | |
Comment 4•5 years ago
|
||
Attachment #8983301 -
Flags: review?(surkov.alexander)
![]() |
Assignee | |
Comment 5•5 years ago
|
||
Attachment #8983302 -
Flags: review?(dtownsend)
![]() |
Assignee | |
Comment 6•5 years ago
|
||
Attachment #8983303 -
Flags: review?(dtownsend)
Comment 7•5 years ago
|
||
Comment on attachment 8983301 [details] [diff] [review] part 3. Stop using nsITreeColumns in accessibility code Review of attachment 8983301 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/base/nsCoreUtils.cpp @@ +527,4 @@ > if (!cols) > return nullptr; > > + RefPtr<nsTreeColumn> column = cols->GetFirstColumn(); It doesn't have to be a refptr, but the change will bloat your patch. If you could file a follow up good-first-bug on this, it'd be great. ::: accessible/xul/XULTreeAccessible.cpp @@ +626,5 @@ > > if (endCol == -1) { > + // We need to make sure to cast to int32_t before we do the subtraction, in > + // case the column count is 0. > + endCol = int32_t(treeColumns->Count()) - 1; shouldn't you use static_cast instead of c-style casting?
Attachment #8983301 -
Flags: review?(surkov.alexander) → review+
![]() |
Assignee | |
Comment 8•5 years ago
|
||
> If you could file a follow up good-first-bug on this, it'd be great. You mean to make it a TreeColumn*? > shouldn't you use static_cast instead of c-style casting? I can do that, sure.
Comment 9•5 years ago
|
||
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #8) > > If you could file a follow up good-first-bug on this, it'd be great. > > You mean to make it a TreeColumn*? Right, that would require to make nsCoreUtils::GetFirstSensibleColumn returning a raw pointer as well, plus bunch of related changes.
Updated•5 years ago
|
Attachment #8983299 -
Flags: review?(dtownsend) → review+
Updated•5 years ago
|
Attachment #8983300 -
Flags: review?(dtownsend) → review+
Updated•5 years ago
|
Attachment #8983302 -
Flags: review?(dtownsend) → review+
Updated•5 years ago
|
Attachment #8983303 -
Flags: review?(dtownsend) → review+
Comment 10•5 years ago
|
||
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/34467aba5393 part 1. Mark nsITreeColumns builtinclass. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/a122097d4ec3 part 2. Remove use of nsITreeColumns in other xpidl interfaces. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce9fe4210ce part 3. Stop using nsITreeColumns in accessibility code. r=surkov https://hg.mozilla.org/integration/mozilla-inbound/rev/2095e4b302d2 part 4. Stop using nsITreeColumns in various other C++ code. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/2628bc75afae part 5. Remove the nsITreeColumns interface. r=mossop
Updated•5 years ago
|
Priority: -- → P3
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/34467aba5393 https://hg.mozilla.org/mozilla-central/rev/a122097d4ec3 https://hg.mozilla.org/mozilla-central/rev/1ce9fe4210ce https://hg.mozilla.org/mozilla-central/rev/2095e4b302d2 https://hg.mozilla.org/mozilla-central/rev/2628bc75afae
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•