Closed Bug 1466707 Opened 2 years ago Closed 1 year ago

image.animation_mode = none doesn't block animated GIFs embedded in SVGs

Categories

(Core :: ImageLib, defect, P3)

60 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: erwinm, Assigned: aosmond)

References

()

Details

(Keywords: access)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180516032328

Steps to reproduce:

First, I am photosensitive, so I need to block animation to use the web.

Among many other fixes:

image.animation_mode none
toolkit.cosmeticAnimations_enabled false
ui.caretblinktime 0

These block most animated gifs and most animated pngs.

But they do not block animated gifs in tooltips and probably don't block animated pngs in tooltips.


Actual results:

I visited a Wikipedia page with a link to https://en.wikipedia.org/wiki/Radio_wave . I accidentally moused over the link. A tooltip popped up and punched me with an animated gif from that page.

I actually visited https://en.wikipedia.org/wiki/Radio_wave to try to figure this out. This time Firefox could protect from the animated gif.


Expected results:

Both times, if users disable animation, Firefox should protect against any animated gifs or pngs.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
20180604220149

(In reply to MarjaE from comment #0)
> I visited a Wikipedia page with a link to
> https://en.wikipedia.org/wiki/Radio_wave .

https://en.wikipedia.org/wiki/Radio_Waves
Hover over the "Radio wave" link, preceding "the electromagnetic phenomenon".
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Component: Untriaged → ImageLib
Ever confirmed: true
Keywords: access
OS: Unspecified → All
Product: Firefox → Core
Hardware: Unspecified → All
Summary: about:config fix cannot block animated gifs in tooltips → image.animation_mode = none doesn't block animated GIFs in Wikipedia tooltips
(In reply to Gingerbread Man from comment #1)
> https://en.wikipedia.org/wiki/Radio_Waves
> Hover over the "Radio wave" link, preceding "the electromagnetic phenomenon".

Hmm, I don't see anything animating when I follow those steps. What am I missing?
(In reply to Timothy Nikkel (:tnikkel) from comment #2)
> Hmm, I don't see anything animating when I follow those steps. What am I
> missing?

If you see a static image, I don't know why that could be. I didn't take any additional steps aside from setting image.animation_mode to none in about:config. The change is immediate when viewing the actual article ( https://en.wikipedia.org/wiki/Radio_wave ) but restarting Firefox and clearing the cache makes no difference either.

If you only see text in the tooltip and no image whatsoever, your window size may be too small or zoom level too high.
Thanks, I can see it now.
Assignee: nobody → aosmond
Flags: needinfo?(aosmond)
Priority: -- → P3
In my opinion, imagelib should take ownership of this pref and not make the higher levels propagate it to us. But this is a small fix we can land quickly, and not worry about perfection :).
Flags: needinfo?(aosmond)
Target Milestone: --- → mozilla64
Status: NEW → ASSIGNED
Summary: image.animation_mode = none doesn't block animated GIFs in Wikipedia tooltips → image.animation_mode = none doesn't block animated GIFs embedded in SVGs
Attachment #9016746 - Attachment description: Bug 1466707 - Ensure that animated images embedded in an SVG use animated image mode. → Bug 1466707 - Ensure that animated images always honour the animated image mode.
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81cff62bc428
Ensure that animated images always honour the animated image mode. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/81cff62bc428
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.