Closed Bug 1466731 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11337 - [LayoutNG] Fix flex BODY in quirks mode

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11337 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11337
Details from upstream follow.

Aleks Totic <atotic@chromium.org> wrote:
>  [LayoutNG] Fix flex BODY in quirks mode
>  
>  We were not updating margins correctly inside NGBlockNode::RunOldLayout.
>  Symptom was that BODY(flex) block size was too big when HTML had margins
>  inside quirks mode.
>  
>  Another side effect of this fix is two crashes have gone away.
>  
>  Added explicit test case for BODY(flex) in quirks mode.
>  
>  Bug: 849490
>  Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
>  Change-Id: Id0ce0910144c81fc254646110424f36c898f9ebd
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1086381
>  WPT-Export-Revision: eae79b112be4070c55ea469f228cf571e3c62c12
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68f23429cb70
[wpt PR 11337] - [LayoutNG] Fix flex BODY in quirks mode, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0ea401e3cf
[wpt PR 11337] - [LayoutNG] Fix flex BODY in quirks mode, a=testonly
https://hg.mozilla.org/mozilla-central/rev/fe0ea401e3cf
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.