1466741 - [wpt-sync] Sync PR 11338 - Revert "WaveShaper must output non-zero values even if input is silent"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11338 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11338
Details from upstream follow.

Matt Giuca <[e-mail]> wrote:
>  Revert "WaveShaper must output non-zero values even if input is silent"
>  
>  This reverts commit 325b492fe733ba4c8b2128069a0a232fea1789e3.
>  
>  Reason for revert: Broke webaudio/.../waveshaper-364379.html in
>  webkit_layout_tests. See https://crbug.com/849535
>  
>  Original change's description:
>  > WaveShaper must output non-zero values even if input is silent
>  > 
>  > If the curve for the WaveShaperNode is such that a zero input produces
>  > a non-zero output, the WaveShaperNode needs to output that value even
>  > if the input is silent (or disconnected).
>  > 
>  > Do this by setting the tail time of the processor to 0 or infinity
>  > depending on whether the curve specifies an output value of zero or
>  > not, respectively.
>  > 
>  > Bug: 807301
>  > Test: WaveShaper/silent-inputs.html
>  > Change-Id: I6539d2e00f5d3e624ffaf2810944eb6d53d6f84b
>  > Reviewed-on: https://chromium-review.googlesource.com/896266
>  > Commit-Queue: Raymond Toy <[e-mail]>
>  > Reviewed-by: Hongchan Choi <[e-mail]>
>  > Cr-Commit-Position: refs/heads/master@{#564186}
>  
>  TBR=[e-mail],[e-mail]
>  
>  Change-Id: I29fd96b1a9dd2b87db12867031399b069beba706
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 807301, 849535
>  Reviewed-on: https://chromium-review.googlesource.com/1086647
>  Reviewed-by: Matt Giuca <[e-mail]>
>  Commit-Queue: Matt Giuca <[e-mail]>
>  Cr-Commit-Position: refs/heads/master@{#564359}
>

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 11338 applied with additional changes from upstream: 5007510675fa679ff60a44a9d10ae33903fa275c

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb05b2efcda691206d12c47a150d89043a518e68

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a788ec47a1e
[wpt PR 11338] - Revert "WaveShaper must output non-zero values even if input is silent", a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d18eca3cf3
[wpt PR 11338] - Revert "WaveShaper must output non-zero values even if input is silent", a=testonly

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d1d18eca3cf3

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Result changes from PR not available.