Closed Bug 1466741 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 11338 - Revert "WaveShaper must output non-zero values even if input is silent"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11338 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11338
Details from upstream follow.

Matt Giuca <mgiuca@chromium.org> wrote:
>  Revert "WaveShaper must output non-zero values even if input is silent"
>  
>  This reverts commit 325b492fe733ba4c8b2128069a0a232fea1789e3.
>  
>  Reason for revert: Broke webaudio/.../waveshaper-364379.html in
>  webkit_layout_tests. See https://crbug.com/849535
>  
>  Original change's description:
>  > WaveShaper must output non-zero values even if input is silent
>  > 
>  > If the curve for the WaveShaperNode is such that a zero input produces
>  > a non-zero output, the WaveShaperNode needs to output that value even
>  > if the input is silent (or disconnected).
>  > 
>  > Do this by setting the tail time of the processor to 0 or infinity
>  > depending on whether the curve specifies an output value of zero or
>  > not, respectively.
>  > 
>  > Bug: 807301
>  > Test: WaveShaper/silent-inputs.html
>  > Change-Id: I6539d2e00f5d3e624ffaf2810944eb6d53d6f84b
>  > Reviewed-on: https://chromium-review.googlesource.com/896266
>  > Commit-Queue: Raymond Toy <rtoy@chromium.org>
>  > Reviewed-by: Hongchan Choi <hongchan@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#564186}
>  
>  TBR=rtoy@chromium.org,hongchan@chromium.org
>  
>  Change-Id: I29fd96b1a9dd2b87db12867031399b069beba706
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 807301, 849535
>  Reviewed-on: https://chromium-review.googlesource.com/1086647
>  Reviewed-by: Matt Giuca <mgiuca@chromium.org>
>  Commit-Queue: Matt Giuca <mgiuca@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#564359}
>
PR 11338 applied with additional changes from upstream: 5007510675fa679ff60a44a9d10ae33903fa275c
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a788ec47a1e
[wpt PR 11338] - Revert "WaveShaper must output non-zero values even if input is silent", a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d18eca3cf3
[wpt PR 11338] - Revert "WaveShaper must output non-zero values even if input is silent", a=testonly
https://hg.mozilla.org/mozilla-central/rev/d1d18eca3cf3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Result changes from PR not available.
You need to log in before you can comment on or make changes to this bug.