Closed Bug 1466792 Opened Last year Closed Last year

The memory management comments in public/Utility.h are out of date

Categories

(Core :: JavaScript: GC, enhancement)

61 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

The section starting "Low-level memory management in SpiderMonkey" talks about methods which are no longer present.
Hopefully this is an improvement.  There's probably more that could be done here though.
Attachment #8983345 - Flags: review?(sphink)
Comment on attachment 8983345 [details] [diff] [review]
bug1466792-alloc-comments

Review of attachment 8983345 [details] [diff] [review]:
-----------------------------------------------------------------

Definitely better.

Should there be a mention of partitioned heaps somewhere? I'm not clear on how those work, but I thought these days you *had* to js_free/js_delete memory that was allocated with JS allocation functions.
Attachment #8983345 - Flags: review?(sphink) → review+
(In reply to Steve Fink [:sfink] [:s:] (PTO June 31) from comment #2)
> I thought these days you *had* to js_free/js_delete
> memory that was allocated with JS allocation functions.

Not yet, but this reminds me I need to work on that.  And the restriction will be the other way round, that js_free/js_delete only accept JS allocated memory (the general jemalloc free function accepts memory allocated in any jemalloc heap).
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f72ccbb15426
Update out-of-date memory allocation comments r=sfink
https://hg.mozilla.org/mozilla-central/rev/f72ccbb15426
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.