1466792 - The memory management comments in public/Utility.h are out of date

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Jon Coppeard (:jonco) (PTO until 14th September)]

The section starting "Low-level memory management in SpiderMonkey" talks about methods which are no longer present.

Comment 1

[Jon Coppeard (:jonco) (PTO until 14th September)]

Attachment: bug1466792-alloc-comments

Hopefully this is an improvement.  There's probably more that could be done here though.

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8983345 [details] [diff] [review]
bug1466792-alloc-comments

Review of attachment 8983345 [details] [diff] [review]:
-----------------------------------------------------------------

Definitely better.

Should there be a mention of partitioned heaps somewhere? I'm not clear on how those work, but I thought these days you *had* to js_free/js_delete memory that was allocated with JS allocation functions.

Comment 3

[Jon Coppeard (:jonco) (PTO until 14th September)]

(In reply to Steve Fink [:sfink] [:s:] (PTO June 31) from comment #2)
> I thought these days you *had* to js_free/js_delete
> memory that was allocated with JS allocation functions.

Not yet, but this reminds me I need to work on that.  And the restriction will be the other way round, that js_free/js_delete only accept JS allocated memory (the general jemalloc free function accepts memory allocated in any jemalloc heap).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f72ccbb15426
Update out-of-date memory allocation comments r=sfink

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f72ccbb15426