1466828 - Using --geckoProfile throws at the end when trying to open the profile

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Alexandre Poirot [:ochameau]]

Running the following commands fails with some exception:
$ ./mach talos-test --activeTests damp --geckoProfile --cycles 1 --tppagecycles 1 --geckoProfileEntries 10000000 --subtest complicated.styleeditor

05:28:27     INFO -  Thanks for running Talos locally. Results are in ['/mnt/desktop/gecko-dev/testing/mozharness/build/local.json']
05:28:27     INFO -  Auto-loading this profile in perfhtml.io: /mnt/desktop/gecko-dev/testing/mozharness/build/blobber_upload_dir/profile_damp.zip
05:28:27     INFO -  ['python', '/mnt/desktop/gecko-dev/testing/tools/view_gecko_profile/view_gecko_profile.py', '-b', '/mnt/desktop/gecko-dev/obj-firefox-artifact/dist/bin/firefox', '-p', '/mnt/desktop/gecko-dev/testing/mozharness/build/blobber_upload_dir/profile_damp.zip']
05:28:32     INFO -  view-gecko-profile process failed to start, poll returned: 1

Comment 1

[Robert Wood [:rwood]]

Hi Alexandre, what platform are you running this on? And do these paths exist on your machine?

/mnt/desktop/gecko-dev/testing/tools/view_gecko_profile/view_gecko_profile.py

/mnt/desktop/gecko-dev/obj-firefox-artifact/dist/bin/firefox

/mnt/desktop/gecko-dev/testing/mozharness/build/blobber_upload_dir/profile_damp.zip

Either Firefox or the view_gecko_profile.py script failed to start for some reason.

Comment 2

[Alexandre Poirot [:ochameau]]

I'm on Linux/Ubuntu 17.10.
All these paths are valid.

Comment 3

[Alexandre Poirot [:ochameau]]

Did you tried my command? after a clobber? with artifact builds?

Comment 4

[Robert Wood [:rwood]]

(In reply to Alexandre Poirot [:ochameau] from comment #3)
> Did you tried my command? after a clobber? with artifact builds?

Thanks Alexandre yes it also fails for me on OSX. This was working great so something has changed recently that has broken it. I will look into it, thanks for reporting!

Comment 5

[Robert Wood [:rwood]]

Ah yes, the python requirements for the view-gecko-profile tool weren't being installed in the talos virtualenv, so the tool was failing to launch. It was working for me originally as I must have already had them installed in my virtualenv. Fix incoming...

Comment 6

[Robert Wood [:rwood]]

Attachment: Bug 1466828 - Fix auto-launching of talos gecko profiles in perfhtml.io;

Review commit: https://reviewboard.mozilla.org/r/249402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249402/

Comment 7

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cebc4b7e1915bc676b80d7273cb3588bd5f2eff

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8983550 [details]
Bug 1466828 - Fix auto-launching of talos gecko profiles in perfhtml.io;

https://reviewboard.mozilla.org/r/249402/#review255578

Comment 9

[Robert Wood [:rwood]]

Comment on attachment 8983550 [details]
Bug 1466828 - Fix auto-launching of talos gecko profiles in perfhtml.io;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/249402/diff/1-2/

Comment 10

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ce48eebfa6dfa92184de6488955dc044406c37f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df85e57a2756
Fix auto-launching of talos gecko profiles in perfhtml.io; r=jmaher

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/df85e57a2756

Comment 13

[Alexandre Poirot [:ochameau]]

Thanks a lot, I finally had a chance to try that and it works fine now. It is *very* handy!!

Comment 14

[Robert Wood [:rwood]]

(In reply to Alexandre Poirot [:ochameau] from comment #13)
> Thanks a lot, I finally had a chance to try that and it works fine now. It
> is *very* handy!!

Thanks for the feedback Alexandre, appreciated :)