Closed Bug 1466838 Opened 2 years ago Closed 2 years ago

Update hairlines in door-hangers/search bar to 10% opacity (Dark theme)

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: amylee, Assigned: ntim)

References

Details

Attachments

(2 files)

Hi, 

Please update the hairlines in Dark theme for search bar and door-hangers to 10% opacity (instead of the current 20%). See screenshot for reference. Thanks!
Blocks: 1408121
Priority: -- → P2
Assignee: nobody → ntim.bugs
Comment on attachment 8983693 [details]
Bug 1466838 - Update --panel-separator-color for dark popups according to spec.

https://reviewboard.mozilla.org/r/249516/#review255750
Attachment #8983693 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b94d5b9a491f
Update --panel-separator-color for dark popups according to spec. r=dao
Comment on attachment 8983693 [details]
Bug 1466838 - Update --panel-separator-color for dark popups according to spec.

Approval Request Comment
[Feature/Bug causing the regression]: dark theme darkening
[User impact if declined]: separator color is lighter than it should
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: change a CSS variable value
[String changes made/needed]:
Attachment #8983693 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/b94d5b9a491f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Comment on attachment 8983693 [details]
Bug 1466838 - Update --panel-separator-color for dark popups according to spec.

CSS-only dark theme polish fix. Approved for 61.0b12.
Attachment #8983693 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.