Closed
Bug 1466851
Opened 6 years ago
Closed 6 years ago
Remove some unused tree box object bits
Categories
(Core :: XUL, enhancement, P5)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(3 files)
9.35 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
2.21 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
13.55 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
These properties are not used from either JS or C++, and hence can be removed from both nsITreeBoxObject and TreeBoxObject.webidl. Properties in this bucket: scrollToCell, scrollToColumn, scrollToHorizontalPosition, invalidateColumnRange.
Attachment #8983514 -
Flags: review?(dtownsend)
Assignee | ||
Comment 2•6 years ago
|
||
These properties are unused from C++ and the FakeTreeBoxObject implementations in comm-central are throwing stubs. So it's safe to remove the properties from nsITreeBoxObject (but not TreeBoxObject.webidl, since they're used in JS). Properties in this bucket: horizontalPosition, getPageLength.
Attachment #8983518 -
Flags: review?(dtownsend)
Updated•6 years ago
|
Priority: -- → P5
Assignee | ||
Comment 3•6 years ago
|
||
These properties are unused from C++ apart from webidl bindings and the FakeTreeBoxObject implentations in comm-central are throwing stubs. But they're used in JS. They are safe to remove from nsITreeBoxObject but we need to keep an implementation webidl can call into. Properties in this bucket: selectionRegion, ensureCellIsVisible, scrollToRow, scrollByLines, scrollByPages, getRowAt, removeImageCacheEntry.
Attachment #8983519 -
Flags: review?(dtownsend)
Updated•6 years ago
|
Attachment #8983514 -
Flags: review?(dtownsend) → review+
Updated•6 years ago
|
Attachment #8983518 -
Flags: review?(dtownsend) → review+
Updated•6 years ago
|
Attachment #8983519 -
Flags: review?(dtownsend) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b8e7ac3a4a5 part 1. Remove some unused tree box object properties. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/99016a1b4105 part 2. Remove some nsITreeBoxObject properties that are unused from C++. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/ada451d2e78d part 3. Remove some nsITreeBoxObject properties that are unused except via webidl bindings. r=mossop
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5b8e7ac3a4a5 https://hg.mozilla.org/mozilla-central/rev/99016a1b4105 https://hg.mozilla.org/mozilla-central/rev/ada451d2e78d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•