1466860 - TRR: update to latest DOH draft version

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Daniel Stenberg [:bagder]]

Currently Firefox runs a version of the DNS-over-HTTPS protocol that matches the -04 version of the draft (https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-04) but there have been several changes to it since.

Including:

 - The query string used in GET requests
 - The Content-Type set in requests
 - The accepted Content-Type in responses

Needs to take Bug 1446404 into consideration and also the implementation state of the end-points existing users are most likely using.

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: bug 1466860 - upgrade DOH code to draft-12 level

MozReview-Commit-ID: FSVh7qUbBig

Comment 2

[Daniel Stenberg [:bagder]]

Server interop status

Cloudflare: check
Google: nope (awaiting answer on specifics)

Comment 3

[Phabricator Automation]

Comment on attachment 8998111 [details]
bug 1466860 - upgrade DOH code to draft-12 level

Patrick McManus [:mcmanus] has approved the revision.

https://phabricator.services.mozilla.com/D2828

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b493b05dcbd5
upgrade DOH code to draft-12 level r=mcmanus

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b493b05dcbd5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something that can ride the trains or does it need a Beta uplift request?

Comment 7

[Daniel Stenberg [:bagder]]

Comment on attachment 8998111 [details]
bug 1466860 - upgrade DOH code to draft-12 level

Thanks for asking. I'm requesting an uplift of this to keep the DoH-support in 62 at fine level.

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: This patch ups Firefox' DoH support to the latest spec draft, which is the one likely to ship as RFC soon. The wire format is not expected to change anything further.
[Is this code covered by automated tests?]: Yes, and this patch updates the test.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: The change is simple and there are very few users of DoH on 62, and they've all opted in via manual prefs edits.
[String changes made/needed]: none

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8998111 [details]
bug 1466860 - upgrade DOH code to draft-12 level

Keeping 62 opt-in users to the newest spec sounds good to me. 
Let's uplift for beta 18.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e8db9f7d2225