Closed Bug 1466870 Opened 3 years ago Closed 3 years ago

Update Debugger Frontend v63

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: davidwalsh, Assigned: davidwalsh)

References

Details

Attachments

(1 file, 2 obsolete files)

Assignee: nobody → dwalsh
Priority: -- → P3
Attached patch debugger-63.patch (obsolete) — Splinter Review
Attachment #8983448 - Flags: review?(jdescottes)
Comment on attachment 8983448 [details] [diff] [review]
debugger-63.patch

Review of attachment 8983448 [details] [diff] [review]:
-----------------------------------------------------------------

Try is orange, the reps update breaks the jsonviewer because it requires "Services". 
"Services" cannot be used in the json viewer because it runs in a specific with 0 access to chrome privileged APIs.
Attachment #8983448 - Flags: review?(jdescottes) → review-
Issue comes from https://github.com/devtools-html/debugger.html/pull/6311 

We can either use something similar to devtools/client/shared/webpack/shims/app-constants-stub.js to perform the platform check without Services or drop the commit from the release.
Attached patch release-63-2.patch (obsolete) — Splinter Review
Attachment #8983448 - Attachment is obsolete: true
Attachment #8983783 - Flags: review?(jdescottes)
Comment on attachment 8983783 [details] [diff] [review]
release-63-2.patch

Review of attachment 8983783 [details] [diff] [review]:
-----------------------------------------------------------------

Update looks good, thanks David! 
Can we add a README update (or delete the file completely if we decided to no longer update it).

Let's wait on that + try before landing.
Attachment #8983783 - Flags: review?(jdescottes) → review+
Attachment #8983783 - Attachment is obsolete: true
Attachment #8983788 - Flags: review?(jdescottes)
Attachment #8983788 - Flags: review?(jdescottes) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb38aa5ce628
Update Debugger Frontend v63 r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/cb38aa5ce628
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.