Open
Bug 1466902
Opened 6 years ago
Updated 2 years ago
[mozlint] Ignore untracked files
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(Not tracked)
NEW
People
(Reporter: ahal, Unassigned)
References
Details
We never want to lint untracked files. This is a little difficult to implement because the underlying linters don't normally know anything about version control. For example, if I run |mach lint browser|, we forward the "browser" path wholesale to e.g, eslint. ESlint will do its own filtering and lint all relevant files under /browser. Checking for untracked files would mean expanding the "/browser" directory to a recursive list of every file it contains, then filtering out all of the files that aren't tracked. This would likely be prohibitively slow. I'm not really sure how to solve this efficiently, but it's at least worth having on file.
Reporter | ||
Comment 1•6 years ago
|
||
Actually, it would be a lot easier to filter out the results of untracked files after the fact (the set of files containing errors should be much smaller than the set of files being linted). The downside to doing this is that we'd still be linting things unnecessarily, but at least they wouldn't be showing up as errors.
Updated•5 years ago
|
Version: Version 3 → 3 Branch
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•