Closed Bug 1466915 Opened 6 years ago Closed 6 years ago

Tabs hang and video frame will flicker/blink/flash or stay black after landing patches from bug #1465008

Categories

(Core :: Graphics: Layers, defect)

62 Branch
x86_64
Windows 7
defect
Not set
blocker

Tracking

()

VERIFIED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 + verified

People

(Reporter: Virtual, Assigned: sotaro)

References

Details

(4 keywords)

Attachments

(2 files)

STR1:
1. Open some website page with video (e.g. YouTube)
2. Start playback
3. Open some hyperlink in background tab
and see that video frame will flicker/blink/flash on background tab opening

STR2:
1. Open some website page with video (e.g. YouTube)
2. Start playback
3. Open some hyperlink in background tab
and see that video frame will stay black

STR3:
1. Open some website page with video (e.g. YouTube)
2. Start playback
3. Open some hyperlink in background tab
and see that video frame will stay black
4. Open more and more hyperlinks in background tabs
and enjoy tabs hang - all tabs will be nonoperational and spinner will be spinning forever, only browser restart fixes this



Regression caused by:
bug #1465008

Regression pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=d3f3359aafd7159c228240ce37d2258e05e92fe1&full=1
Flags: needinfo?(sotaro.ikeda.g)
Has Regression Range: --- → yes
Has STR: --- → yes
:Virtual, can you attach the contents of your about:support when the problem happen? Thanks.
Flags: needinfo?(sotaro.ikeda.g) → needinfo?(Virtual)
Assignee: nobody → sotaro.ikeda.g
I could reproduce STR1 in comment 0.

It happened because ImageClients were dropped when it is not necessary(non device reset case).
See Also: → 1467055
Flags: needinfo?(Virtual)
Attachment #8983656 - Flags: review?(nical.bugzilla)
Attached file about:support.txt
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> :Virtual, can you attach the contents of your about:support when the problem
> happen? Thanks.

Sure, but contents of about:support doesn't change (no additional new errors or warnings in Graphics section) when issue occurred.
Thanks, I just wanted to know if about:support was changed.
Tracking to make sure we land/verify a fix or else back out the regressing work in bug 1465008.
:nical, can you review the patch? thanks.
Flags: needinfo?(nical.bugzilla)
Attachment #8983656 - Flags: review?(nical.bugzilla) → review+
Flags: needinfo?(nical.bugzilla)
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/837bebcb78f9
Add D3DDevice check in ImageBridgeChild::UpdateTextureFactoryIdentifier r=nical
https://hg.mozilla.org/mozilla-central/rev/837bebcb78f9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
I'm confirming that issue is fixed, starting in Mozilla Firefox Nightly 62.0a1 (2018-06-14), so I'm marking this bug as VERIFIED. Thank you very much! \o/
Status: RESOLVED → VERIFIED
Keywords: dogfood
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: