Closed Bug 1466929 Opened 2 years ago Closed 2 years ago

Intermittent browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Uncaught exception - Should have only the expected folders in the list - timed out after 50 tries | Should have correctly re-ordered the list

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: standard8)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fxsearch])

Attachments

(1 file, 1 obsolete file)

Filed by: nerli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=181931088&repo=autoland

https://queue.taskcluster.net/v1/task/RSIIvZqNRuOzm_l-KLe0qA/runs/0/artifacts/public/logs/live_backing.log

[task 2018-06-05T18:38:50.723Z] 18:38:50     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Should have no recent folders to start with. - [] deepEqual [] - 
[task 2018-06-05T18:38:50.723Z] 18:38:50     INFO - Buffered messages logged at 18:38:40
[task 2018-06-05T18:38:50.723Z] 18:38:50     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Should have one folder in the list. - ["j-LDf-PB9Egv"] deepEqual ["j-LDf-PB9Egv"] - 
[task 2018-06-05T18:38:50.724Z] 18:38:50     INFO - Leaving test bound test_remember_last_folder
[task 2018-06-05T18:38:50.725Z] 18:38:50     INFO - Entering test bound test_forget_oldest_folder
[task 2018-06-05T18:38:50.726Z] 18:38:50     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Should have only the expected folders in the list - ["j-LDf-PB9Egv"] deepEqual ["j-LDf-PB9Egv"] - 
[task 2018-06-05T18:38:50.727Z] 18:38:50     INFO - Buffered messages logged at 18:38:42
[task 2018-06-05T18:38:50.729Z] 18:38:50     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Should have only the expected folders in the list - ["KZfUNea9Eb2c","j-LDf-PB9Egv"] deepEqual ["KZfUNea9Eb2c","j-LDf-PB9Egv"] - 
[task 2018-06-05T18:38:50.730Z] 18:38:50     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Should have only the expected folders in the list - ["bdKyI3Dgeyiw","KZfUNea9Eb2c","j-LDf-PB9Egv"] deepEqual ["bdKyI3Dgeyiw","KZfUNea9Eb2c","j-LDf-PB9Egv"] - 
[task 2018-06-05T18:38:50.731Z] 18:38:50     INFO - Buffered messages finished
[task 2018-06-05T18:38:50.740Z] 18:38:50     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Uncaught exception - Should have only the expected folders in the list - timed out after 50 tries.
[task 2018-06-05T18:38:50.744Z] 18:38:50     INFO - Leaving test bound test_forget_oldest_folder
[task 2018-06-05T18:38:50.745Z] 18:38:50     INFO - Entering test bound test_reorder_folders
[task 2018-06-05T18:38:50.749Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,sortingMode:..,sortingAnnotation:..,suppressNotifications:..,addObserver:..,removeObserver:..,root:.., } Need to have a result to update
[task 2018-06-05T18:38:50.750Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,parent:..,parentResult:..,uri:..,type:..,title:..,accessCount:..,time:..,icon:..,indentLevel:..,bookmarkIndex:..,itemId:..,dateAdded:..,lastModified:..,tags:..,pageGuid:..,bookmarkGuid:..,visitId:..,fromVisitId:..,visitType:..,containerOpen:..,state:..,hasChildren:..,childCount:..,getChild:..,getChildIndex:..,RESULT_TYPE_URI:..,RESULT_TYPE_QUERY:..,RESULT_TYPE_FOLDER:..,RESULT_TYPE_SEPARATOR:..,RESULT_TYPE_FOLDER_SHORTCUT:..,STATE_CLOSED:..,STATE_LOADING:..,STATE_OPENED:..,query:..,queryOptions:..,folderItemId:..,targetFolderGuid:.., } null container
[task 2018-06-05T18:38:50.752Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,parent:..,parentResult:..,uri:..,type:..,title:..,accessCount:..,time:..,icon:..,indentLevel:..,bookmarkIndex:..,itemId:..,dateAdded:..,lastModified:..,tags:..,pageGuid:..,bookmarkGuid:..,visitId:..,fromVisitId:..,visitType:..,containerOpen:..,state:..,hasChildren:..,childCount:..,getChild:..,getChildIndex:..,RESULT_TYPE_URI:..,RESULT_TYPE_QUERY:..,RESULT_TYPE_FOLDER:..,RESULT_TYPE_SEPARATOR:..,RESULT_TYPE_FOLDER_SHORTCUT:..,STATE_CLOSED:..,STATE_LOADING:..,STATE_OPENED:..,query:..,queryOptions:..,folderItemId:..,targetFolderGuid:.., } null container
[task 2018-06-05T18:38:50.753Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,sortingMode:..,sortingAnnotation:..,suppressNotifications:..,addObserver:..,removeObserver:..,root:.., } Need to have a result to update
[task 2018-06-05T18:38:50.754Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,parent:..,parentResult:..,uri:..,type:..,title:..,accessCount:..,time:..,icon:..,indentLevel:..,bookmarkIndex:..,itemId:..,dateAdded:..,lastModified:..,tags:..,pageGuid:..,bookmarkGuid:..,visitId:..,fromVisitId:..,visitType:..,containerOpen:..,state:..,hasChildren:..,childCount:..,getChild:..,getChildIndex:..,RESULT_TYPE_URI:..,RESULT_TYPE_QUERY:..,RESULT_TYPE_FOLDER:..,RESULT_TYPE_SEPARATOR:..,RESULT_TYPE_FOLDER_SHORTCUT:..,STATE_CLOSED:..,STATE_LOADING:..,STATE_OPENED:..,query:..,queryOptions:..,folderItemId:..,targetFolderGuid:.., } null container
[task 2018-06-05T18:38:50.756Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,parent:..,parentResult:..,uri:..,type:..,title:..,accessCount:..,time:..,icon:..,indentLevel:..,bookmarkIndex:..,itemId:..,dateAdded:..,lastModified:..,tags:..,pageGuid:..,bookmarkGuid:..,visitId:..,fromVisitId:..,visitType:..,containerOpen:..,state:..,hasChildren:..,childCount:..,getChild:..,getChildIndex:..,RESULT_TYPE_URI:..,RESULT_TYPE_QUERY:..,RESULT_TYPE_FOLDER:..,RESULT_TYPE_SEPARATOR:..,RESULT_TYPE_FOLDER_SHORTCUT:..,STATE_CLOSED:..,STATE_LOADING:..,STATE_OPENED:..,query:..,queryOptions:..,folderItemId:..,targetFolderGuid:.., } null container
[task 2018-06-05T18:38:50.756Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,parent:..,parentResult:..,uri:..,type:..,title:..,accessCount:..,time:..,icon:..,indentLevel:..,bookmarkIndex:..,itemId:..,dateAdded:..,lastModified:..,tags:..,pageGuid:..,bookmarkGuid:..,visitId:..,fromVisitId:..,visitType:..,containerOpen:..,state:..,hasChildren:..,childCount:..,getChild:..,getChildIndex:..,RESULT_TYPE_URI:..,RESULT_TYPE_QUERY:..,RESULT_TYPE_FOLDER:..,RESULT_TYPE_SEPARATOR:..,RESULT_TYPE_FOLDER_SHORTCUT:..,STATE_CLOSED:..,STATE_LOADING:..,STATE_OPENED:..,query:..,queryOptions:..,folderItemId:..,targetFolderGuid:.., } null container
[task 2018-06-05T18:38:50.759Z] 18:38:50     INFO - GECKO(2739) | console.assert: {QueryInterface:..,parent:..,parentResult:..,uri:..,type:..,title:..,accessCount:..,time:..,icon:..,indentLevel:..,bookmarkIndex:..,itemId:..,dateAdded:..,lastModified:..,tags:..,pageGuid:..,bookmarkGuid:..,visitId:..,fromVisitId:..,visitType:..,containerOpen:..,state:..,hasChildren:..,childCount:..,getChild:..,getChildIndex:..,RESULT_TYPE_URI:..,RESULT_TYPE_QUERY:..,RESULT_TYPE_FOLDER:..,RESULT_TYPE_SEPARATOR:..,RESULT_TYPE_FOLDER_SHORTCUT:..,STATE_CLOSED:..,STATE_LOADING:..,STATE_OPENED:..,query:..,queryOptions:..,folderItemId:..,targetFolderGuid:.., } null container
[task 2018-06-05T18:38:50.759Z] 18:38:50     INFO - GECKO(2739) | console.error: (new TypeError("this._batchBlockingDeferred is null", "chrome://browser/content/browser-places.js", 341))
[task 2018-06-05T18:38:50.760Z] 18:38:50     INFO - GECKO(2739) | console.error: (new TypeError("this._batchBlockingDeferred is null", "chrome://browser/content/browser-places.js", 341))
[task 2018-06-05T18:38:50.763Z] 18:38:50     INFO - GECKO(2739) | [Parent 2739, Main Thread] WARNING: Must complete empty transaction when compositing!: file /builds/worker/workspace/build/src/layout/base/PresShell.cpp, line 6240
Mark, any idea?
Blocks: 1460579
Flags: needinfo?(standard8)
Yeah, I was concerned this might happen. I'll have another think about it.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)
Priority: P5 → P1
Whiteboard: [fxsearch]
Summary: Intermittent browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Uncaught exception - Should have only the expected folders in the list - timed out after 50 tries. → Intermittent browser/components/places/tests/browser/browser_bookmarkProperties_remember_folders.js | Uncaught exception - Should have only the expected folders in the list - timed out after 50 tries | Should have correctly re-ordered the list
Duplicate of this bug: 1467133
Duplicate of this bug: 1467329
Attachment #8983718 - Attachment is obsolete: true
Ensure we wait for the onItemMoved notification before proceeding, to avoid async issues. Also improve the wait for checks to provide better debug.
Comment on attachment 8984097 [details]
Bug 1466929 - Fix intermittent issues in browser_bookmarkProperties_remember_folders.js.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1579
Attachment #8984097 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d7a1f17b573
Fix intermittent issues in browser_bookmarkProperties_remember_folders.js. r=mak
https://hg.mozilla.org/mozilla-central/rev/4d7a1f17b573
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.