1466970 - [wpt-sync] Sync PR 11359 - [css-contain] Disable layout containment for certain elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11359 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11359
Details from upstream follow.

Manuel Rego Casasnovas <[e-mail]> wrote:
>  [css-contain] Disable layout containment for certain elements
>  
>  Text from the spec
>  (https://drafts.csswg.org/css-contain/#containment-layout):
>    "... if the element is an internal table element other than
>    display: table-cell, or if the element is an internal ruby element,
>    or if the element’s principal box is a non-atomic inline-level box,
>    layout containment has no effect."
>  
>  The patch disables "contain: layout" for internal table elements
>  but table cells, internal ruby elements and
>  non-atomic inline-level boxes.
>  
>  Some of the new tests pass or fail incidentally due to crbug.com/785212,
>  once that's fixed all the tests should be working as expected.
>  
>  BUG=843329
>  TEST=external/wpt/css/css-contain/contain-layout-008.html
>  TEST=external/wpt/css/css-contain/contain-layout-009.html
>  TEST=external/wpt/css/css-contain/contain-layout-010.html
>  TEST=external/wpt/css/css-contain/contain-layout-011.html
>  TEST=external/wpt/css/css-contain/contain-layout-012.html
>  TEST=external/wpt/css/css-contain/contain-layout-013.html
>  TEST=external/wpt/css/css-contain/contain-layout-014.html
>  
>  Change-Id: I5f0893a9ce69dc8e76cf16acb1b8556bf0e02adf
>  Reviewed-on: https://chromium-review.googlesource.com/1087268
>  Reviewed-by: Emil A Eklund <[e-mail]>
>  Commit-Queue: Manuel Rego Casasnovas <[e-mail]>
>  Cr-Commit-Position: refs/heads/master@{#564631}
>

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ba8fb2528aff85ee734c3b322bbfeefc9f6fae9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=abe0147da53f9b69d5f7460d7c2a77c9a645a8f0

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 7 tests
PASS   : 4
FAIL   : 3

New tests that have failures or other problems:
/css/css-contain/contain-layout-008.html: FAIL
/css/css-contain/contain-layout-013.html: FAIL
/css/css-contain/contain-layout-014.html: FAIL

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28bcacafede4
[wpt PR 11359] - [css-contain] Disable layout containment for certain elements, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/97f58661d408
[wpt PR 11359] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d65994953a36
[wpt PR 11359] - [css-contain] Disable layout containment for certain elements, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/941d66b8c3ae
[wpt PR 11359] - Update wpt metadata, a=testonly

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d65994953a36
https://hg.mozilla.org/mozilla-central/rev/941d66b8c3ae