Closed Bug 1467055 Opened 5 years ago Closed 5 years ago

Video flickering after pushing "Trigger Device Reset"

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

patch - Do not reuse D3D11Textures when CompositorDevice or ContentDevice is updated
2.23 KB, patch
nical
: review+
Details | Diff | Splinter Review 
During youtube playback, if "Trigger Device Reset" button in about:support is pushed. It caused video rendering flickering.
Blocks: 1188006
When D3D11RecycleAllocator::CreateOrRecycleClient() stopped to recycle D3D11Textures, the problem did not happen. From it, we could not reuse D3D11Textures when CompositorDevice or ContentDevice is updated.
See Also: → 1466915
Assignee: nobody → sotaro.ikeda.g
Attachment #8983684 - Flags: review?(nical.bugzilla)
Attachment #8983684 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27da7e98059b
Do not reuse D3D11Textures when CompositorDevice or ContentDevice is updated r=nical
https://hg.mozilla.org/mozilla-central/rev/27da7e98059b
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
I saw that on Firefox 62 Beta the "Trigger Device Reset" button doesn't appear; the button appears only on Nightly builds. Is there any additional set-up needed in order to confirm the fix on Firefox 62 Beta builds?
Flags: needinfo?(sotaro.ikeda.g)
From the following source, "Trigger Device Reset" button is enabled only Nightly or Developer Edition. Can Developer Edition be  used for testing of Firefox 62 Beta?

https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutSupport.js#365
Flags: needinfo?(sotaro.ikeda.g)
You need to log in before you can comment on or make changes to this bug.