Closed Bug 1467117 Opened Last year Closed Last year

Devtools tab sorting is not properly implementing sort()

Categories

(DevTools :: Shared Components, defect, P3)

61 Branch
defect

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

From the review for bug 1226272: the sort logic at https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/devtools/client/framework/toolbox-tabs-order-manager.js#164-169 is wrong.

Sort should take a function comparing two arguments, not simply return an integer based on a single item.
The sort is actually completely redundant now, since we sort again right after based on the tabsOrder preference. We should simply remove it.
Comment on attachment 8983781 [details]
Bug 1467117 - remove unneeded sort() of devtools definitions;

https://reviewboard.mozilla.org/r/249624/#review255822

Thanks Julian!
Though I think this change is no problem, to be safe, I threw to the try.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c796700006a4b7f3d16fd7cde3b2c0716efab4c

Please wait until the result.
Thanks Daisuke! try is green, except for known intermittents.
Comment on attachment 8983781 [details]
Bug 1467117 - remove unneeded sort() of devtools definitions;

https://reviewboard.mozilla.org/r/249624/#review256012

Thanks!
Attachment #8983781 - Flags: review?(dakatsuka) → review+
Assignee: nobody → jdescottes
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/884f30832a45
remove unneeded sort() of devtools definitions;r=daisuke
https://hg.mozilla.org/mozilla-central/rev/884f30832a45
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.