1467164 - [Admin control panel] New preference experiment cannot be published from the first revision

Status: RESOLVED WORKSFORME

(Firefox :: Normandy Server, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Environment:]
Win10, Win8.1, Ubuntu 16.04, OSx 10.13.4

[Prerequisites:]
1. Access to https://normandy-admin.stage.mozaws.net

[Steps:]
1. Open https://normandy-admin.stage.mozaws.net.
2. Create a pref-expermient type recipe.
3. Request Approval.
4. Approve.
5. Publish.

[Actual Result:]
The pref-experiment recipe shall not be published. Browser console:
Error: Bad Request control.a5580d5cb7459e78b7f9.js:1:66458

[Expected Result:]
Recipe should be published.

[Work around:]
Revision the recipe and publish shall work.

[Note:]
Version flags are not relevant for this issue.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Updates:
- this issue affects only pref-experiments;
- this issue doesn't affect preference-rollout, preference-rollback, show-heartbeat, opt-out-study;
- this issue affects Staging (https://normandy-admin.stage.mozaws.net/) - don't have access to test if production exhibits this bug;

Mike, I would guess that Admin control panel has some kind of versioning. It would be useful for future reference to have that version listed somewhere.

Comment 2

[Michael Cooper [:mythmon]]

The version is listed in https://normandy-admin.stage.mozaws.net/__version__. Not very user friendly, but it works. We should file an issue on Delivery Console to make sure they do better in the future.

I looked into this a bit, and I think I understand what's going on now. The error the network is returning says "Experiment slugs must be globally unique". That check has different behavior for the first revision on the server, which explainss this well. This should be a pretty easy fix.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/abdf4d6360272d7bb8b89bb25cfad3e1d943782f
Bug  1467164 - Correctly check arguments for new preference experiments

https://github.com/mozilla/normandy/commit/62f7f3127f22d7c3c6db28821d8724bfa6256dfe
Merge #1401

1401: Bug  1467164 - Correctly check arguments for new preference experiments r=rehandalal a=mythmon

Without this check, it isn't possible to enable a revision that only has one revision.

Co-authored-by: Mike Cooper <[e-mail]>

Comment 4

[Adrian Florinescu [:aflorinescu]]

I think that this can be marked as WFM.