1467173 - Color boxes not are aligned in the Colors subdialog

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Alexandru Simonca [:asimonca], Release Desktop QA]

Attachment: printscreen of misaligned boxes

[Affected versions]:
- Tested on Beta 61.0b11

[Affected platforms]:
- All

[Steps to reproduce]:
1. Navigate to about:preferences
2. Under "Language and Appearance" press the "Colors..." button

[Expected result]:
- The dialog looks correct

[Actual result]:
- The color boxes and the check box with the string "Underline links" are misaligned relative to text on the left side.

[Regression range]:
- This issue was introduced by the new localization API.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Screenshot from 2018-06-06 10-36-02.png

Can you provide more information please? I'm attaching a screenshot from today's nightly and while it looks slightly different from your screenshot, both seem aligned to me?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screen Shot 2018-06-07 at 10.07.27 AM.png

With gandalf's screenshot, using xScope's ruler, I can see the misalignment.

Comment 3

[:Gijs (he/him)]

This doesn't look like it's fluent-related. Instead it's a regression from bug 1392517.

Comment 4

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

The situation is the same on both nightly and beta builds. They are only off by a few pixels, so we drew the straight lines to point this out.

Comment 5

[Morgan Reschenberg [:morgan]]

Attachment: corrected_dialog

This seems corrected in the latest nightly; can someone confirm?

Comment 6

[:Gijs (he/him)]

Yes. I ran mozregression --find-fix, and it seems this got fixed in October 2018. 😬

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2872e7a3606d6108874930a1eb4062c74bad0e9e&tochange=c9f6d6242851d25e230bc6a81fb45bfc8f93e6c1

Probably bug 1493844 ?