146719 - Menupopups of menulists do not honor Windows XP/2k theme (shadow)

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Håkan Waara]

Reproduced in RC2.

If I click on a menu, or if a tooltip pops up, there is a visible shadow behind
the popup -- according to the XP theme preferences. However, if I click a
menupopupbutton, like the criteria popups in the Search Message dialog, no
shadow will be behind these menus.

Comment 1

[Andreas Kunz]

Håkan, IE has also such popups without shadow, e.g. in "Internet
Options"/"Programs" (or similar, this is translated from the german version).
I'm not sure which popups are supposed to have shadows and which not...
Bug 196619 deals with a similar issue and has some screenshots and talk.

Comment 2

[Andreas Kunz]

*** Bug 196619 has been marked as a duplicate of this bug. ***

Comment 3

[Andreas Kunz]

Bug 196619 has screenshots, but it's pretty clear:
Bug 118368 introduced the shadows, but explicitly prevented them from appearing
below menupopups that originate from menulists.

As stated in comment #1, IE (and other hative Windows applications like the MMC)
also have no shadows below those, so I think this is invalid though sometimes
looking strange.
The _real_ bug might be that menupopups opened from menupopups that were opened
from a menulist (nice, huh?) DO have a shadow (see attachment 141329 [details]). Did not
find such a thing in native Windows apps yet.

This might be caused by
widgetData.mDropShadow = !(tag && tag == nsXULAtoms::menulist);
in the patch for bug 118368 - only looking at the own parent, not the parent's
parent in case the own parent is a menupopup itself.
 

Comment 4

[Alfred Kayser]

This bug can be closed? The shadows were fixed about a week ago

Comment 5

[Jason Bassford]

No specific bug / patch referenced as the fix.  (The referenced bugs all seem to
be the opposite, actually.)

-> WORKSFORME