1467204 - The Cancel Job button sometimes requires multiple clicks

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I've noticed over the past couple days that the first click of the cancel job button doesn't always "take". At first I'd chalked it up to user error or a faulty memory on my part, but I was able to systematically reproduce it yesterday with it typically taking two clicks for the cancellation request to go through.

I asked in the #sheriffs channel and the SV shift at the time was also able to reproduce.

Comment 1

[Cameron Dawson [:camd]]

Ryan: this is the cancel button on the navbar on the left of the bottom details pane, right?  Not cancel all pinned jobs in the pinboard?  Just making sure.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Correct, but TBH, I'm having a hard time reproducing now. Leaving the NI on myself to let this percolate a day or two. I'll get back to you :)

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3670

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c9f0d6c1939f7be546ea2218815f408004fb8bfd
Bug 1467204 - Fix Cancel Job button not showing success notification (#3670)