Closed Bug 1467215 Opened 5 years ago Closed 5 years ago

Marionette is reported enabled when it fails to initialise

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox61 fixed, firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(2 files)

Bug 1467215 - Abort initialisation on fatal error.
59 bytes, text/x-review-board-request
impossibus
: review+
Details
Bug 1467215 - Reset prefs possibly set by failed init.
59 bytes, text/x-review-board-request
impossibus
: review+
Details 
When Marionette component initialisation fails, we fail to prevent
Marionette from reporting itself as enabled:

> [task 2018-06-06T17:20:02.966Z] 17:20:02     INFO -  1528305602959	Marionette	FATAL	Remote protocol server failed to start: [Exception... "File error: Not found"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: jar:file:///builds/worker/workspace/build/application/firefox/omni.ja!/components/marionette.js :: init/< :: line 444"  data: no] Stack trace: init/<()@jar:file:///builds/worker/workspace/build/application/firefox/omni.ja!/components/marionette.js:444
> [task 2018-06-06T17:20:03.028Z] 17:20:03     INFO -  1528305603021	Marionette	DEBUG	Remote service is active
Assignee: nobody → ato
Blocks: marionette-window-tracking
Status: NEW → ASSIGNED
Comment on attachment 8983887 [details]
Bug 1467215 - Abort initialisation on fatal error.

https://reviewboard.mozilla.org/r/249732/#review255944

::: commit-message-04cc9:5
(Diff revision 1)
> +Bug 1467215 - Abort initialisation on fatal error. r?maja_zf
> +
> +When the Marionette component fails to initialise we fail to bail
> +out.  This causes Marionette to report itself as enabled through
> +an environment variable, an observer nortification, and a log message.

typo notification
Attachment #8983887 - Flags: review?(mjzffr) → review+
Comment on attachment 8983888 [details]
Bug 1467215 - Reset prefs possibly set by failed init.

https://reviewboard.mozilla.org/r/249734/#review255946
Attachment #8983888 - Flags: review?(mjzffr) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b9c59172bc1
Abort initialisation on fatal error. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/19607304a6b7
Reset prefs possibly set by failed init. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/0b9c59172bc1
https://hg.mozilla.org/mozilla-central/rev/19607304a6b7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Sheriffs: Uplift to beta if possible, please.
Whiteboard: [checkin-needed-beta]
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.