146722 - Enable HP IPF (ia64) XPTcall code

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Jim Dunn]

We received code from HP for getting the xptcall code working
on HP-UXB.11.20 IPF (ia64 machine) and part of the code was
modifying mozilla/xpcom/reflect/xptcall/public/genstubs.pl

I don't fully understand it, but if we are going to get mozilla
working on IPF (Itanium Processor Family) then we are going to 
either have to use it or come up with something else.

The code is (NOTE: this is not the final patch, I realize that
I need to ifdef for HP & ia64, but I wanted to get feedback)

Index: xpcom/reflect/xptcall/public/genstubs.pl
===================================================================
RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/public/genstubs.pl,v
retrieving revision 1.5
diff -u -r1.5 genstubs.pl
--- xpcom/reflect/xptcall/public/genstubs.pl    19 May 2001 00:03:00 -0000      1.5
+++ xpcom/reflect/xptcall/public/genstubs.pl    23 May 2002 11:58:51 -0000
@@ -38,9 +38,17 @@
 print OUTFILE "*  1 is AddRef\n";
 print OUTFILE "*  2 is Release\n";
 print OUTFILE "*/\n";
+print OUTFILE "#ifndef __ia64\n";
 for($i = 0; $i < $entry_count; $i++) {
     print OUTFILE "XPTC_EXPORT NS_IMETHOD Stub",$i+3,"();\n";
 }
+print OUTFILE "#else\n";
+for($i = 0; $i < $entry_count; $i++) {
+    print OUTFILE "XPTC_EXPORT NS_IMETHOD Stub",$i+3,"(PRUint64,\n";
+    print OUTFILE " PRUint64,PRUint64,PRUint64,PRUint64,PRUint64,PRUint64);\n";
+
+}
+print OUTFILE "#endif\n";
 
 print OUTFILE "\n/* declarations of sentinel stubs */\n";
 
----------
Apparently this matches up with xpcom/xptcall/src/md/unix/xptcstubs_ipf32.cpp
because at the bottom, the definition of STUBS_ENTRY has a comment:

/* Variable a0-a7 were put there so we can have access to 
 *  the 8 input registers on Stubxyz entry
 */

Comment 1

[Jim Dunn]

updating...

Comment 2

[Martin Lawyer]

Attachment: Complete patch, OEM branch

Comment 3

[Jim Dunn]

note: for the trunk we need to work on this...

Comment 4

[Martin Lawyer]

Changes checked into OEM branch.

Comment 5

[Martin Lawyer]

Attachment: trunk patch, better #ifdefs

Patch updated for trunk check in.   Added an extra #ifdef to more specifically
target only HPUX ia64 machines.

Comment 6

[Martin Lawyer]

Attachment: Trunk patch revised

Extraneous lines removed

Comment 7

[David Bradley]

Comment on attachment 102978 [details] [diff] [review]
Trunk patch revised

r=dbradley

Can't vouch for the details, but looks ok, and will only affect the ia64 HP
systems.

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 102978 [details] [diff] [review]
Trunk patch revised

This is fine, yeah.  Drivers: let's take this for 1.4 -- simple, safe port fix.

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 102978 [details] [diff] [review]
Trunk patch revised

since this only affects HPUX, and the HPUX folks want it, and they want to ship
1.4, a=sspitzer

Comment 10

[Jim Dunn]

fix checked in

Comment 11

[Phil Schwartau]

Checkin verified -