Closed Bug 1467260 Opened Last year Closed Last year

Intermittent gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_fixed_in_scrolled_transform.html | fixed item inside a scrolling transform hit info - got "VISIBLE | DISPATCH_TO_CONTENT", expected "VISIBLE"

Categories

(Core :: Panning and Zooming, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kats)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=182121144&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/SEWd1NKYRPmJHAADwTjGyQ/runs/0/artifacts/public/logs/live_backing.log

17:15:02     INFO -  1127 INFO TEST-START | gfx/layers/apz/test/mochitest/test_group_hittest.html
17:15:02     INFO -  GECKO(7316) | Parent process: flushed APZ repaints, waiting for callback...
17:15:02     INFO -  GECKO(7316) | Flushed APZ repaints, waiting for callback...
17:15:02     INFO -  GECKO(7316) | Hit-testing point (208, 250)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (108, 450)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (349.5, 122)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (80, 391.5)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (208, 250)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (108, 233)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (349.5, 122)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (349.5, 361)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (80, 391.5)
17:15:02     INFO -  GECKO(7316) | Hit-testing point (319, 391.5)
17:15:05     INFO -  GECKO(7316) | Parent process: flushed APZ repaints, waiting for callback...
17:15:05     INFO -  GECKO(7316) | Flushed APZ repaints, waiting for callback...
17:15:05     INFO -  GECKO(7316) | Hit-testing point (316.5, 30)
17:15:07     INFO -  GECKO(7316) | Parent process: flushed APZ repaints, waiting for callback...
17:15:07     INFO -  GECKO(7316) | Flushed APZ repaints, waiting for callback...
17:15:07     INFO -  GECKO(7316) | Hit-testing point (30, 57.5)
17:15:07     INFO -  TEST-INFO | started process screenshot
17:15:08     INFO -  TEST-INFO | screenshot: exit 0
17:15:08     INFO -  Buffered messages logged at 17:15:02
17:15:08     INFO -  1128 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1129 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe hit info
17:15:08     INFO -  1130 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe scrollid
17:15:08     INFO -  1131 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1132 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe - apzaware block hit info
17:15:08     INFO -  1133 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe - apzaware block scrollid
17:15:08     INFO -  1134 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1135 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe - vertical scrollbar hit info
17:15:08     INFO -  1136 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe - vertical scrollbar scrollid
17:15:08     INFO -  1137 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1138 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe - horizontal scrollbar hit info
17:15:08     INFO -  1139 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | inactive scrollframe - horizontal scrollbar scrollid
17:15:08     INFO -  1140 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1141 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe hit info
17:15:08     INFO -  1142 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe scrollid
17:15:08     INFO -  1143 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1144 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - apzaware block hit info
17:15:08     INFO -  1145 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - apzaware block scrollid
17:15:08     INFO -  1146 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1147 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - vertical scrollbar hit info
17:15:08     INFO -  1148 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - vertical scrollbar scrollid
17:15:08     INFO -  1149 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1150 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - vertical scrollbar hit info
17:15:08     INFO -  1151 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - vertical scrollbar scrollid
17:15:08     INFO -  1152 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1153 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - horizontal scrollbar hit info
17:15:08     INFO -  1154 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - horizontal scrollbar scrollid
17:15:08     INFO -  1155 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1156 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - horizontal scrollbar hit info
17:15:08     INFO -  1157 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_basic.html | active scrollframe - horizontal scrollbar scrollid
17:15:08     INFO -  Buffered messages logged at 17:15:05
17:15:08     INFO -  1158 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_float_bug1434846.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  1159 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_float_bug1434846.html | inactive scrollframe - vertical scrollbar hit info
17:15:08     INFO -  1160 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_float_bug1434846.html | inactive scrollframe - vertical scrollbar scrollid
17:15:08     INFO -  Buffered messages logged at 17:15:07
17:15:08     INFO -  1161 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_float_bug1443518.html | Expected at least one hit result in the APZTestData
17:15:08     INFO -  Buffered messages finished
17:15:08    ERROR -  1162 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_float_bug1443518.html | inactive scrollframe - horizontal scrollbar hit info - got "VISIBLE", expected "VISIBLE | DISPATCH_TO_CONTENT | SCROLLBAR"
17:15:08     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:312:5
17:15:08     INFO -      spawnTest/w.is@gfx/layers/apz/test/mochitest/apz_test_utils.js:243:45
17:15:08     INFO -      checkHitResult@gfx/layers/apz/test/mochitest/apz_test_utils.js:566:3
17:15:08     INFO -      hitTestScrollbar@gfx/layers/apz/test/mochitest/apz_test_utils.js:657:5
17:15:08     INFO -      test@gfx/layers/apz/test/mochitest/helper_hittest_float_bug1443518.html:40:3
17:15:08     INFO -      driveTest@gfx/layers/apz/test/mochitest/apz_test_utils.js:404:19
17:15:08     INFO -      runContinuation/</<@gfx/layers/apz/test/mochitest/apz_test_utils.js:410:7
17:15:08     INFO -      runContinuation/<@gfx/layers/apz/test/mochitest/apz_test_utils.js:397:12
17:15:08     INFO -      setTimeout handler*repaintDone@gfx/layers/apz/test/mochitest/apz_test_utils.js:122:7
17:15:08     INFO -  1163 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_float_bug1443518.html | inactive scrollframe - horizontal scrollbar scrollid
17:15:10     INFO -  GECKO(7316) | Parent process: flushed APZ repaints, waiting for callback...
17:15:10     INFO -  GECKO(7316) | Flushed APZ repaints, waiting for callback...
I expect bug 1466549 to fix this. (specifically servo/webrender#2797)
Assignee: nobody → bugmail
Depends on: 1466549
The link in the previous comment only shows two failures. One is the original failure that prompted this bug, and that I believe was fixed. The other is https://treeherder.mozilla.org/logviewer.html#?job_id=182688992&repo=mozilla-central&lineNumber=17379 which is a failure in helper_hittest_fixed_in_scrolled_transform.html, a newly added test. It's possible that test has a bug and isn't flushing stuff properly or something.

I'll morph this bug to track that issue, but it's low volume so far so I probably won't look at it right away.
Blocks: 1465935
Summary: Intermittent gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_float_bug1443518.html | inactive scrollframe - horizontal scrollbar hit info - got "VISIBLE", expected "VISIBLE | DISPATCH_TO_CONTENT | SCROLLBAR" → Intermittent gfx/layers/apz/test/mochitest/test_group_hittest.html | helper_hittest_fixed_in_scrolled_transform.html | fixed item inside a scrolling transform hit info - got "VISIBLE | DISPATCH_TO_CONTENT", expected "VISIBLE"
I think the problem here is the same as what I described at https://bugzilla.mozilla.org/show_bug.cgi?id=1438752#c25 - the mochitests are basically doing this:
  setDisplayPortForElement(...); // activate scrollframe
  yield waitForAllPaints(...); // flushes paints over PCompositorBridge
  checkResult(hitTest(...)); // sends event over PContent to parent process

So it's possible that the hitTest gets to APZ before the paint, and so we'll get the "inactive" scrollframe hit result instead of the active scrollframe hit result.

Changing the waitForAllPaints to a waitForApzFlushedRepaints should fix this.
Comment on attachment 8985009 [details]
Bug 1467260 - Ensure scrollframe activation is processed by APZ before doing hit-test checks.

https://reviewboard.mozilla.org/r/250736/#review256986
Attachment #8985009 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ba3ea055cc3
Ensure scrollframe activation is processed by APZ before doing hit-test checks. r=botond
https://hg.mozilla.org/mozilla-central/rev/5ba3ea055cc3
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.