1467311 - Bustage on workspace/build/src/image/test/gtest/TestSurfaceSink.cpp when Gecko 62 merges to Beta on 14-06-2018

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Raul Gurzau (:RaulG)]

Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e86b8661d1973ae88b4b8a6f9f01396ac9238512

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=182084154&repo=try&lineNumber=17331

Log snippet:
[task 2018-06-06T13:47:04.754Z] 13:47:04     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/image/test/gtest'
[task 2018-06-06T13:47:04.757Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_image_test_gtest0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/image/test/gtest -I/builds/worker/workspace/build/src/obj-firefox/image/test/gtest -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/gfx/2d -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation --coverage -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fomit-frame-pointer -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_image_test_gtest0.o.pp   /builds/worker/workspace/build/src/obj-firefox/image/test/gtest/Unified_cpp_image_test_gtest0.cpp
[task 2018-06-06T13:47:04.758Z] 13:47:04     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/image/test/gtest/Unified_cpp_image_test_gtest0.cpp:137:0:
[task 2018-06-06T13:47:04.760Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp: In function 'ImageSurfaceSink_SurfaceSinkWritePixelBlocksPartialRow_Test::TestBody()::<lambda(mozilla::image::Decoder*, mozilla::image::SurfaceSink*)>':
[task 2018-06-06T13:47:04.760Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:665:62: error: '<anonymous>' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.760Z] 13:47:04     INFO -                                       : BGRAColor::Transparent().AsPixel();
[task 2018-06-06T13:47:04.760Z] 13:47:04     INFO -                                                                ^
[task 2018-06-06T13:47:04.760Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:665:62: error: '*((void*)&<anonymous> +1)' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.760Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:665:62: error: '*((void*)&<anonymous> +2)' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.761Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:665:62: error: '*((void*)&<anonymous> +3)' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:664:56: error: '<anonymous>' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -         buffer[i] = 20 <= i && i < 80 ? BGRAColor::Green().AsPixel()
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -                                                          ^
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:664:56: error: '*((void*)&<anonymous> +1)' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:664:56: error: '*((void*)&<anonymous> +2)' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/image/test/gtest/TestSurfaceSink.cpp:664:56: error: '*((void*)&<anonymous> +3)' is used uninitialized in this function [-Werror=uninitialized]
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -  cc1plus: all warnings being treated as errors
[task 2018-06-06T13:47:04.763Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1031: recipe for target 'Unified_cpp_image_test_gtest0.o' failed
[task 2018-06-06T13:47:04.764Z] 13:47:04     INFO -  make[4]: *** [Unified_cpp_image_test_gtest0.o] Error 1
[task 2018-06-06T13:47:04.764Z] 13:47:04     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/image/test/gtest'
[task 2018-06-06T13:47:04.764Z] 13:47:04     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'image/test/gtest/target' failed
[task 2018-06-06T13:47:04.764Z] 13:47:04     INFO -  make[3]: *** [image/test/gtest/target] Error 2
[task 2018-06-06T13:47:04.764Z] 13:47:04     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

These tests were added in bug 1382683. All of the fields are initialized though so I'm not sure why it is unhappy. We do the same thing at line 388 higher up, and it doesn't complain.

https://searchfox.org/mozilla-central/rev/cf464eabfeba64e866c1fa36b9fefd674dca9c51/image/test/gtest/TestSurfaceSink.cpp#388

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Okay, I think the optimizer just went insane. I was able to get it to build/link (although it failed later for an unrelated reason) with some non-functional fiddling with the code. I reorganized that into something that hopefully also builds, but makes some kind of sense rather than "just don't touch this line."

https://treeherder.mozilla.org/#/jobs?repo=try&revision=73fffc5e0da4769ce2ea685742addc1c20894313
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a5543bfc11e914e6fd299c692838cb83aab18c0

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Andrew Osmond [:aosmond] from comment #2)
> Okay, I think the optimizer just went insane. I was able to get it to
> build/link (although it failed later for an unrelated reason) with some
> non-functional fiddling with the code. I reorganized that into something
> that hopefully also builds, but makes some kind of sense rather than "just
> don't touch this line."
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=73fffc5e0da4769ce2ea685742addc1c20894313
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=5a5543bfc11e914e6fd299c692838cb83aab18c0

Once again the build failed in the end, but properly linked and got past the reported problem. I assume it is unrelated.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e996438ca500
Fix linux64-ccov/opt beta test build bustage. r=aosmond

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e996438ca500