Closed Bug 1467335 Opened 3 years ago Closed 3 years ago

Add an assertion to ungetCharIgnoreEOL that the EOF-flag has been set if EOF is being returned

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(1 file)

A basic "why haven't we done this already for belt-and-suspenders awareness" sort of thing.
Attached patch PatchSplinter Review
Attachment #8984000 - Flags: review?(arai.unmht)
Blocks: 1467336
Comment on attachment 8984000 [details] [diff] [review]
Patch

Review of attachment 8984000 [details] [diff] [review]:
-----------------------------------------------------------------

makes sense :)
Attachment #8984000 - Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de25c66a84b0
Add an assertion to ungetCharIgnoreEOL that the EOF-flag has been set if EOF is being returned.  r=arai
https://hg.mozilla.org/mozilla-central/rev/de25c66a84b0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.