Closed
Bug 1467379
Opened 6 years ago
Closed 6 years ago
nsStyleGradientStop: Replace nsColor with StyleComplexColor
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: u480271, Assigned: u480271)
References
Details
Attachments
(2 files)
No description provided.
Assignee: nobody → dglastonbury
Status: NEW → ASSIGNED
Priority: -- → P3
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8984318 [details] Bug 1467379 - P1: nsStyleGradientStop - Change nscolor to StyleComplexColor. https://reviewboard.mozilla.org/r/250132/#review256422 Please add a testcase for this, ideally as a wpt reftest, checking that currentcolor is inherited as a keyword in computed value correctly when used in gradient.
Attachment #8984318 -
Flags: review?(xidorn+moz) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8985254 [details] Bug 1467379 - P2: Reftest for currentcolor in gradient stop color. https://reviewboard.mozilla.org/r/250868/#review257154
Attachment #8985254 -
Flags: review?(xidorn+moz) → review+
Pushed by dglastonbury@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f4dfe45a8ed P1: nsStyleGradientStop - Change nscolor to StyleComplexColor. r=xidorn https://hg.mozilla.org/integration/autoland/rev/171096f4da3d P2: Reftest for currentcolor in gradient stop color. r=xidorn
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2f4dfe45a8ed https://hg.mozilla.org/mozilla-central/rev/171096f4da3d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•