1467400 - Disable JavaScript should not be available in the browser toolbox

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

[Affected versions]: 
- Firefox 61.0b3
- Firefox 60, Fx55, Fx52

[Affected platforms]:
- Windows 8.1 x64
- Mac OS X 10.13
- Ubuntu 14.04 x64.

[Steps to reproduce]:

1. Open Firefox. 
2. Open some websites in different tabs.
3. Open the Inspector by pressing F12. 
4. Click on the Meatball Menu then on settings menu item.
5. From Advanced settings section enable "Enable browser chrome and add-on debugging toolboxes" and "Enable remote debugging"
6. Go to Tools -> Web Developer -> Browser Toolbox to display the Developer Tools window.
7. Click on the Meatball Menu/Settings then from Advanced settings section check Disable JavaScript checkbox.

[Actual result]:
All the opened tabs were closed. After restarting Firefox all tabs reopened.

[Expected result]:
I'm not sure what should happened, but on Inspector page checking the Disable JavaScript checkbox no tabs were closed.

[Regression range]:
- This is not a recent regression, it reproduces back to Fx 52.

Comment 1

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: test11.gif

Comment 2

[Patrick Brosset <:pbro>]

Thanks for filing. I also do not know what should happen exactly tbh. Let me ping Mike who should be able to clarify the wanted behavior.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

So here we are disabling JavaScript inside the browser itself and reloading the UI, which fails because there is no JS.

Disabling JS shouldn't be available from the browser debugger because it is applied to the tab containing the toolbox.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1467400 - Disable JavaScript should not be available in the browser toolbox

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 9003829 [details]
Bug 1467400 - Disable JavaScript should not be available in the browser toolbox

A one liner to disable the disable JS option in the options panel when inside the browser toolbox.

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9003829 [details]
Bug 1467400 - Disable JavaScript should not be available in the browser toolbox

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b410bf97457
Disable JavaScript should not be available in the browser toolbox r=gl

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4b410bf97457

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 63.0a1 on Win 8.1 x64, Mac OS X 10.13 and Ubuntu 18.04 x64.