1467478 - The 'Unpin from Overflow Menu' option does not restore the icon to its previous location

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect, P5)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: The 'Unpin from Overflow Menu' behavior

[Affected versions]:
- Fx 62.0a1
- Fx 61.0b11
- Fx 56.0a1

[Affected platforms]:
- Windows 10 x64
- Unbuntu 16.04 x64
- macOS 10.13.4

[Steps to reproduce]:
1. Launch Firefox.
2. Right click the home button and choose the 'Send to Overflow Menu' option.
3. Open the Overflow menu.
4. Right click the Home button and choose the 'Unpin from Overflow menu' option.

[Expected result]:
- The button is restored in the place (or at least general area) from where it was sent to the overflow menu.

[Actual result]:
- The button is restored beside the Overflow menu arrows.

[Regression range]:
- This is not a regression. It's the same behavior from when the Overflow menu (for tools) was introduced.

[Additional notes]:
- Moving the tool icon back to its original position would increase the user experience a lot since it would spare him the time of going through the customization menu edit in order to get it back to the place he was used to.

Comment 1

[:Gijs (he/him)]

This requires keeping track of where items were before. It also becomes more confusing when you add/remove multiple items, and then add them back in a different order - it's not clear how to easily keep track of the "original" order when items get restored in another order.

I think this UI feature is not used often enough to justify spending time on implementing this. If people want more finegrained control we provide this through customize mode. If anything, I'd sooner implement drag/drop customization outside customize mode, for which we already have a bug on file. Philipp, would you be OK closing this as wontfix?

Comment 2

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #1)
> This requires keeping track of where items were before. It also becomes more
> confusing when you add/remove multiple items, and then add them back in a
> different order - it's not clear how to easily keep track of the "original"
> order when items get restored in another order.

To make this clear, let's say you started with:


[a][b][c][d]

you move items to the overflow menu in alphabetical order.

Then you right click [c] in the overflow menu and move it back, then [a], then [b] etc. How to keep track of things so that the order is exactly the same as before, and/or not "messy" ? At least right now the behavior is predictable (always at the end).

Comment 3

[:Gijs (he/him)]

Restoring to the 'old' position also assumes that the user moves items back soon after moving it to the overflow menu, and remembers where the 'right' place is. Otherwise it might just look like we're restoring it to a 'random' place in the toolbar...

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Yes, I agree that this is a wontfix.