1467509 - Remove opening of alert from interactive tutorial

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[jmdyck]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180517113603

Steps to reproduce:

I was following the interactive tutorial at:
    http://marionette-client.readthedocs.io/en/master/interactive.html
I got to:
    client.execute_script("alert('o hai there!');")
and that worked, and then the instructions say "Close the dialog", so I closed it by clicking the "OK" button. Then I entered the next statement.


Actual results:

I got an uncaught exception:
marionette_driver.errors.NoAlertPresentException: No modal dialog is currently open


Expected results:

I gather that that *is* what should have happened, i.e. marionette doesn't like when you mix human interaction with automation. In which case, the bug is in the tutorial: rather than saying "Close the dialog", it should give the statements necessary to close the dialog via marionette. (Or else drop the step that opens a dialog.)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, that's not ideal. Instead of opening a pop-up we should do something with the site which has to be opened in the next step. Lets say we could return the window title.

Pop-ups are special and we do not yet correctly handle all of them. So lets get rid of that part.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1467509 - [marionette] Update execute_script command in interactive tutorial. , a=doc

Review commit: https://reviewboard.mozilla.org/r/250272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250272/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8984429 [details]
Bug 1467509 - [marionette] Update execute_script command in interactive tutorial. , a=doc

https://reviewboard.mozilla.org/r/250272/#review256560

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2140cc056ad0
[marionette] Update execute_script command in interactive tutorial. r=whimboo, a=doc

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2140cc056ad0