Closed Bug 1467512 Opened 8 years ago Closed 7 years ago

[wpt-sync] Sync PR 11379 - Worker: Use Document's SettingsObject for top-level module script loading on dedicated workers

Categories

(Core :: DOM: Workers, enhancement, P4)

Product:
Core
Component:
DOM: Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11379 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11379 Details from upstream follow. Hiroki Nakagawa <nhiroki@chromium.org> wrote: > Worker: Use Document's SettingsObject for top-level module script loading on dedicated workers > > This CL makes Document serve its settings object ("outside settings") to > WorkerGlobalScope based on the following HTML spec: > > Step 13. "Fetch a module worker script graph given url, outside settings, > destination, the value of the credentials member of options, and inside > settings." > https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model > > This SettingsObject is used as "fetch client settings object" for top-level > module script loading and static imports. > > Before this CL, WorkerGlobalScope's settings object ("inside_settings_object") > is used as "fetch client settings object". This is obviously wrong and fails > some web-platform-tests. This change fixes them. > > Change-Id: I87a78f38308e262425b848d99dc617dbddeb81e7 > Bug: 842553, 845285 > > Reviewed-on: https://chromium-review.googlesource.com/1084133 > WPT-Export-Revision: e2d2ee8298f2f3898ecd22baa19fcf8833244149
PR 11379 applied with additional changes from upstream: 4b4c626fc8602d1d06680a7d298789708fae5cd3
Component: web-platform-tests → DOM: Workers
Product: Testing → Core
Ran 1 tests and 15 subtests TIMEOUT: 2 NOTRUN : 14 New tests that have failures or other problems: /workers/modules/dedicated-worker-import-referrer.html: TIMEOUT Cross-origin dynamic import with "no-referrer" referrer policy.: NOTRUN Cross-origin dynamic import with "origin" referrer policy.: NOTRUN Cross-origin dynamic import with "same-origin" referrer policy.: NOTRUN Cross-origin static import with "no-referrer" referrer policy.: NOTRUN Cross-origin static import with "origin" referrer policy.: NOTRUN Cross-origin static import with "same-origin" referrer policy.: NOTRUN Same-origin dynamic import with "no-referrer" referrer policy.: NOTRUN Same-origin dynamic import with "origin" referrer policy.: NOTRUN Same-origin dynamic import with "same-origin" referrer policy.: NOTRUN Same-origin static import with "no-referrer" referrer policy.: NOTRUN Same-origin static import with "origin" referrer policy.: NOTRUN Same-origin static import with "same-origin" referrer policy.: NOTRUN Same-origin top-level module script loading with "no-referrer" referrer policy: TIMEOUT Same-origin top-level module script loading with "origin" referrer policy: NOTRUN Same-origin top-level module script loading with "same-origin" referrer policy: NOTRUN
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/6880a2a5cfe0 [wpt PR 11379] - Worker: Use Document's SettingsObject for top-level module script loading on dedicated workers, a=testonly
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/680d6f0eb09d [wpt PR 11379] - Worker: Use Document's SettingsObject for top-level module script loading on dedicated workers, a=testonly
https://hg.mozilla.org/mozilla-central/rev/680d6f0eb09d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.