Closed Bug 1467549 Opened Last year Closed Last year

Disable the BackgroundHangReporter in ASan builds

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

BHR is causing frequent intermittent leaks (bug 1445441), and I don't think there's any easy way to fix it. It is already disabled in debug builds (I was wondering why we weren't seeing this leak there...) so we might as well just disable it in ASan, too. ASan builds are likely slow enough that BHR is getting hit a lot more, too. (I don't know if that's an argument for or against disabling it in ASan builds.)
Summary: Disable the BackgroundHangReporter on ASan builds → Disable the BackgroundHangReporter in ASan builds
Blocks: 1461697
Comment on attachment 8984276 [details]
Bug 1467549 - Disable the BackgroundHangReporter in ASan builds.

https://reviewboard.mozilla.org/r/250080/#review257632

:-/ oh well - sure.
Attachment #8984276 - Flags: review?(nika) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bad278043bc9
Disable the BackgroundHangReporter in ASan builds. r=Nika
Backed out changeset bad278043bc9 (bug 1467549) for build bustage on asan builds. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=183869865&repo=autoland&lineNumber=132637

INFO -  package> z:/build/build/src/toolkit/mozapps/installer/packager.mk:22: recipe for target 'stage-package' failed
22:50:05     INFO -  package> mozmake.EXE[5]: *** [stage-package] Error 1
22:50:05     INFO -  package> mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer'
22:50:05     INFO -  package> z:/build/build/src/toolkit/mozapps/installer/packager.mk:88: recipe for target 'make-package' failed
22:50:05     INFO -  package> mozmake.EXE[4]: *** [make-package] Error 2
22:50:05     INFO -  package> z:/build/build/src/config/rules.mk:418: recipe for target 'default' failed
22:50:05     INFO -  package> mozmake.EXE[3]: *** [default] Error 2
22:50:05     INFO -  package> z:/build/build/src/browser/build.mk:6: recipe for target 'package' failed
22:50:05     INFO -  package> mozmake.EXE[2]: *** [package] Error 2
22:50:05     INFO -  z:/build/build/src/build/moz-automation.mk:89: recipe for target 'automation/package' failed
22:50:05     INFO -  mozmake.EXE[1]: *** [automation/package] Error 2
22:50:05     INFO -  mozmake.EXE[1]: *** Waiting for unfinished jobs....
22:50:25     INFO -  package-tests> mozmake.EXE[2]: Entering directory 'z:/build/build/src/obj-firefox'
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.process_install_manifest --track install__test_files.track _tests _build_manifests/install/_test_files
22:50:25     INFO -  package-tests> Elapsed: 22.75s; From _tests: Kept 0 existing; Added/updated 34687; Removed 0 files and 0 directories.
22:50:25     INFO -  package-tests> mozmake.EXE[2]: Leaving directory 'z:/build/build/src/obj-firefox'
22:50:25     INFO -  package-tests> mozmake.EXE[2]: Entering directory 'z:/build/build/src/obj-firefox'
22:50:25     INFO -  package-tests> rm -rf dist/test-stage
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -D dist/test-stage
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -D dist/test-stage/bin
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -D dist/test-stage/bin/components
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -D dist/test-stage/certs
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -D dist/test-stage/config
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -D dist/test-stage/modules
22:50:25     INFO -  package-tests> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -D dist/test-stage/tools/mach
22:50:25     INFO -  package-tests> mozmake.EXE[2]: Leaving directory 'z:/build/build/src/obj-firefox'
22:50:25     INFO -  package-tests> z:/build/build/src/mozmake.EXE -C ./js/src/tests stage-package
22:50:26     INFO -  package-tests> mozmake.EXE[2]: Entering directory 'z:/build/build/src/obj-firefox'
22:50:26     INFO -  package-tests> cp z:/build/build/src/testing/tools/mach_test_package_bootstrap.py dist/test-stage/tools/mach_bootstrap.py
22:50:26     INFO -  package-tests> cp z:/build/build/src/mach dist/test-stage

Push wtih failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bad278043bc9ae7b0570bbec9c59d2578401becf&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Backout:
https://hg.mozilla.org/integration/autoland/rev/508f1ee4b3326e52b2b03fd63fc594ef3c92b23a
Flags: needinfo?(continuation)
I thought I'd done a try run, but I guess not! Looks like something is breaking in make package.

; NOTE: This must match the config checks in
; /toolkit/components/backgroundhangmonitor/moz.build.

Aha...
Flags: needinfo?(continuation)
I updated the two package files (Android and desktop), then did a try run with Linux ASan, Linux, and Android. Hopefully that's enough. https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b766edaed5012c3335fafdf8a8656b1caf250cf
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f46c81aa31d
Disable the BackgroundHangReporter in ASan builds. r=Nika
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/2111f47f89cc
Disable the BackgroundHangReporter in ASan builds. r=Nika
https://hg.mozilla.org/mozilla-central/rev/2111f47f89cc
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/756c9cd2c176
Port bug 1467549 to TB [Disable the BackgroundHangReporter in ASan builds]. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.