Closed Bug 1467670 Opened Last year Closed Last year
Base::Insert From Drop
46 bytes, text/x-phabricator-request
|Details | Review|
InsertFromDrop is implemeted on TextEditor only and it is called from EditorEventListenr. So we should not use virtual.
InsertFromDrop is implemented on TextEditor only, so it can do devirtualize this method. Also, this method is only called by drop event handler of EditorEventListener, so it should rename to better name (OnDrop).
Comment on attachment 8984342 [details] Bug 1467670 - Devirtualize InsertFromDrop. r?masayuki Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision. https://phabricator.services.mozilla.com/D1592
Attachment #8984342 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f86b968525a8 Devirtualize InsertFromDrop. r=masayuki
You need to log in before you can comment on or make changes to this bug.