Closed Bug 1467670 Opened Last year Closed Last year

Devirtualize EditorBase::InsertFromDrop

Categories

(Core :: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

InsertFromDrop is implemeted on TextEditor only and it is called from EditorEventListenr.  So we should not use virtual.
InsertFromDrop is implemented on TextEditor only, so it can do devirtualize
this method.  Also, this method is only called by drop event handler of
EditorEventListener, so it should rename to better name (OnDrop).
Comment on attachment 8984342 [details]
Bug 1467670 - Devirtualize InsertFromDrop. r?masayuki

Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision.

https://phabricator.services.mozilla.com/D1592
Attachment #8984342 - Flags: review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/f86b968525a8
Devirtualize InsertFromDrop. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/f86b968525a8
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.