1467691 - Make some methods of EditorBase non-public

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

NotifyEditorObservers() and GetInputEventTargetContent() and IsModifiableNode() are used only by editor classes or their friends. So, they shouldn't be public methods.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=410f85984c80e594b759d1db8591acd4f85f538e

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467691 - Make some methods of EditorBase non-public

This moves NotifyEditorObservers() and GetInputEventTargetContent() into
protected member which should not be used by friends.

And also this moves IsModifiableNode() into protected member which can be
used by friends.

Review commit: https://reviewboard.mozilla.org/r/250176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250176/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8984363 [details]
Bug 1467691 - Make some methods of EditorBase non-public

https://reviewboard.mozilla.org/r/250176/#review256802

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f077e2d6e30e
Make some methods of EditorBase non-public r=m_kato

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f077e2d6e30e