Closed Bug 1467694 Opened 6 years ago Closed 6 years ago

drop support for landing patches that are missing the `diff start line` header

Categories

(Conduit Graveyard :: Transplant, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

drop support for landing patches that are missing the `diff start line` header.

lando should always send this, and we only accept patches from lando.
Assignee: nobody → glob
dropping for for this in production only.

this isn't ideal, however as we need to test pulling the patch from a
url, and mercurial doesn't add this header, we either drop those tests
all together, or only place this limitation in production.
Comment on attachment 8994419 [details]
Bug 1467694 - drop support for landing patches that are missing the `diff start line` header r=smacleod

Steven MacLeod [:smacleod] has approved the revision.

https://phabricator.services.mozilla.com/D2314
Attachment #8994419 - Flags: review+
https://github.com/mozilla-conduit/autoland-transplant/commit/1b2b5e5270b051a321b495151a902fcd5380dfb9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
deployed to prod.
Product: Conduit → Conduit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: