1467696 - multiple emails from phabricator after commenting on a bug (subscriber/cc changes)

Status: RESOLVED WONTFIX

(Conduit :: General, defect, P2)

Description

[:glob ✱]

in bug 1463195 comment 18 birtles said:
> And now I got spammed 5 emails from Phabricator just because I replied to this bug.

i asked for a copy of the emails and got:

> From: phab-bot (Phabricator Automation User) <[e-mail]>
> Date: Fri, Jun 8, 2018 at 9:24 AM
> Subject: [Differential] [Changed Subscribers] D1362: bzexport: change cmdutil.export to cmdutil.exportfile (Bug 1463195) r?gps
> 
> phab-bot added a subscriber: gps. 

> From: phab-bot (Phabricator Automation User) <[e-mail]>
> Date: Fri, Jun 8, 2018 at 9:24 AM
> Subject: [Differential] [Changed Subscribers] D1364: mozhg: use error.Abort instead of util.Abort (Bug 1463195) r?gps
> 
> phab-bot added a subscriber: gps. 

> From: phab-bot (Phabricator Automation User) <[e-mail]>
> Date: Fri, Jun 8, 2018 at 9:24 AM
> Subject: [Differential] [Changed Subscribers] D1365: bzexport: fix use of deprecated APIs (Bug 1463195) r?gps
> 
> phab-bot added a subscriber: gps. 

> From: phab-bot (Phabricator Automation User) <[e-mail]>
> Date: Fri, Jun 8, 2018 at 9:24 AM
> Subject: [Differential] [Changed Subscribers] D1366: bzexport: update supported versions (Bug 1463195) r?gps
> 
> phab-bot added a subscriber: gps.

birtles also said:

> It seems I get 5 more mails every time someone new replies to the bug.


my guess is commenting on the bug added birtles to the bug's cc list.
this was mirrored across to phabricator where birtles was subscribed to all diffs in the stack.
when gps replied on the bug, he was also added as a subscriber in phabricator, to all five diffs in the stack, generating the 5 emails birtles received.


we may want to see if it's possible to selectively disable subscriber notifications from phabricator; we _may_ want to leave them enabled on non-public bugs, but on public bugs they are noise.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Just to clarify, I received 10 emails. The first 5 were when I commented on the bug. The next 5 were when gps commented.

In the mails I forwarded, there should actually be two emails included (in at least the last 5 I sent, the first one I forwarded was just the first email of the first thread.)

Comment 2

[:glob ✱]

note that as a normal user you can change your email preferences and disable "A revision's CCs change." under "Differential Revisions".

Comment 5

[:glob ✱]

while this isn't ideal, as this only impacts a small set of users (those involved with security bugs) and there's a workaround (comment 2) we're going to wontfix this bug.