1467726 - Make differential's emails better

Status: RESOLVED DUPLICATE of bug 1459996

(Conduit :: Phabricator, enhancement, P5)

Description

[:Gijs (he/him)]

(Probably not the right component, please move as necessary)

Here's an email I just got, in full. The # and * in front of most lines are my modifications:

----
*mythmon created this revision.
*mythmon added a reviewer: Gijs.
#Herald added a project: secure-revision.
#phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
#phab-bot changed the edit policy from "Custom Policy" to "All Users".
#phab-bot removed a project: secure-revision.
*mythmon requested review of this revision.

#REPOSITORY
#rMOZILLACENTRAL mozilla-central

#BRANCH
#default

#REVISION DETAIL
*https://phabricator.services.mozilla.com/D1591

AFFECTED FILES
toolkit/components/normandy/actions/PreferenceRollbackAction.jsm
toolkit/components/normandy/test/browser/browser_actions_PreferenceRollbackAction.js

EMAIL PREFERENCES
https://phabricator.services.mozilla.com/settings/panel/emailpreferences/

#To: mythmon, Gijs
----

Here's my summary:

- all the lines prefixed with "#" can be removed, as well as the additional blank lines
- the lines with * earlier in the email should be unified. I.e. the email should say "mythmon requested review from Gijs on <link-to-revision>"
- the email preferences link should be in a footer, which automatically gets grayed out or elided in most mail clients.
- the email should stop using all-caps and *bold* type
- the email *should* include a link to the relevant bugzilla bug
- the email *should* include the full commit message
- I'm not sure if it's all that useful to include a list of modified files. But I think we should probably only include them if there's 5 files or fewer, and for bigger revisions we should collapse directories ("Modifies 30 files in toolkit/components/normandy, browser/base/content/general and toolkit/modules" or something), rather than dumping all the full file paths in emails.

Comment 1

[Mark Côté [:mcote]]

I agree the emails aren't amazing but I don't think this warrants further customization/extension.  There may be some tweaks we could ask upstream to look at though, so I'll put this on the backlog.